linux-kernel - Re: [PATCH] mm: hugetlb: eliminate memory-less nodes handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e20c2f22-5df7-270c-27c4-13af0d3b3904@redhat.com>
Date:   Thu, 1 Sep 2022 11:03:07 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Aneesh Kumar K V <aneesh.kumar@...ux.ibm.com>,
        Muchun Song <songmuchun@...edance.com>,
        gregkh@...uxfoundation.org, rafael@...nel.org,
        mike.kravetz@...cle.com, akpm@...ux-foundation.org,
        osalvador@...e.de, ying.huang@...el.com, rientjes@...gle.com
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH] mm: hugetlb: eliminate memory-less nodes handling

On 01.09.22 11:00, Aneesh Kumar K V wrote:
> On 9/1/22 2:00 PM, Muchun Song wrote:
>> The memory-notify-based approach aims to handle meory-less nodes, however, it just adds
>> the complexity of code as pointed by David in thread [1].  The handling of memory-less
>> nodes is introduced by commit 4faf8d950ec4 ("hugetlb: handle memory hot-plug events").
>> From its commit message, we cannot find any necessity of handling this case. So, we can
>> simply register/unregister sysfs entries in register_node/unregister_node to simlify the
>> code.
> 
> Isn't that hotplug callback added because in hugetlb_register_all_nodes() we register
> sysfs nodes only for N_MEMORY nodes? 
> 

Right, that needs adjustment as well.


-- 
Thanks,

David / dhildenb