linux-kernel - Re: [PATCH v2 2/9] perf/x86/intel: Move the topdown stuff into the intel driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YxB2Ff9f+pM9W9Zf@hirez.programming.kicks-ass.net>
Date:   Thu, 1 Sep 2022 11:06:29 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     "Liang, Kan" <kan.liang@...ux.intel.com>
Cc:     x86@...nel.org, eranian@...gle.com, ravi.bangoria@....com,
        linux-kernel@...r.kernel.org, acme@...nel.org,
        mark.rutland@....com, alexander.shishkin@...ux.intel.com,
        jolsa@...nel.org, namhyung@...nel.org
Subject: Re: [PATCH v2 2/9] perf/x86/intel: Move the topdown stuff into the
 intel driver

On Wed, Aug 31, 2022 at 09:41:06AM -0400, Liang, Kan wrote:
> >  static void intel_pmu_reset(void)
> >  {
> >  	struct debug_store *ds = __this_cpu_read(cpu_hw_events.ds);
> > @@ -4635,6 +4653,10 @@ static __initconst const struct x86_pmu
> >  	.enable_all		= core_pmu_enable_all,
> >  	.enable			= core_pmu_enable_event,
> >  	.disable		= x86_pmu_disable_event,
> > +
> > +	.set_period		= intel_pmu_set_period,
> > +	.update			= intel_pmu_update,
> 
> I tried the patch, but it impacts the topdown.
> The root cause is that these should be added for intel_pmu rather than
> core_pmu.
> 

Dang; must be a rebase fail on my end, sorry about that. Let me go fix
that.