[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YxCPYbPsEyZmuHOI@sirena.org.uk>
Date: Thu, 1 Sep 2022 11:54:25 +0100
From: Mark Brown <broonie@...nel.org>
To: Lee Steve <steve.lee.analog@...il.com>
Cc: lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
krzk@...nel.org, ryans.lee@...log.com
Subject: Re: [PATCH] ASoC: max98390: Remove unnecessary amp on/off conrtol
On Thu, Sep 01, 2022 at 02:57:19PM +0900, Lee Steve wrote:
> On Thu, Sep 1, 2022 at 1:36 AM Mark Brown <broonie@...nel.org> wrote:
> > I can't see anything which ensures that this is the case? Should there
> > be a check which returns an error if the output is not enabled, or
> > should the function check the current state and preserve it at the end?
> > I can see that this would fix problems with it being disabled when
> > callibrating.
> As your comment, this can fix amp being disabled when calibrating.
> And this also fix the case that music play right after calibration.
> Actually, calibration process should start mute playback before
> trigger this function.
> AMP disable/enable control in calibration function can break sync with
> userspace enable/disable control.
Right, so that sounds like there should be something which checks the
current state and doesn't start callibration unless the device is in a
sensible state.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists