lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202209012046.5sg4d0qh-lkp@intel.com>
Date:   Thu, 1 Sep 2022 20:49:48 +0800
From:   kernel test robot <lkp@...el.com>
To:     Johannes Berg <johannes.berg@...el.com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        Ammar Faizi <ammarfaizi2@...weeb.org>,
        GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
        linux-kernel@...r.kernel.org
Subject: [ammarfaizi2-block:wireless/wireless-next/mld-wip 16/20]
 drivers/net/wireless/st/cw1200/sta.c:198:58: error: too few arguments to
 function call, expected 4, have 3

tree:   https://github.com/ammarfaizi2/linux-block wireless/wireless-next/mld-wip
head:   10cf17b0508f56ee45e15ad2a612b64999264d4f
commit: 60286c25de214ab636d7af34c4c05db0023fd827 [16/20] wifi: mac80211: extend ieee80211_nullfunc_get() for MLO
config: x86_64-randconfig-a003 (https://download.01.org/0day-ci/archive/20220901/202209012046.5sg4d0qh-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/ammarfaizi2/linux-block/commit/60286c25de214ab636d7af34c4c05db0023fd827
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block wireless/wireless-next/mld-wip
        git checkout 60286c25de214ab636d7af34c4c05db0023fd827
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/wireless/st/cw1200/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/net/wireless/st/cw1200/sta.c:198:58: error: too few arguments to function call, expected 4, have 3
                   skb = ieee80211_nullfunc_get(priv->hw, priv->vif, false);
                         ~~~~~~~~~~~~~~~~~~~~~~                           ^
   include/net/mac80211.h:5319:17: note: 'ieee80211_nullfunc_get' declared here
   struct sk_buff *ieee80211_nullfunc_get(struct ieee80211_hw *hw,
                   ^
   drivers/net/wireless/st/cw1200/sta.c:2266:63: error: too few arguments to function call, expected 4, have 3
           frame.skb = ieee80211_nullfunc_get(priv->hw, priv->vif, false);
                       ~~~~~~~~~~~~~~~~~~~~~~                           ^
   include/net/mac80211.h:5319:17: note: 'ieee80211_nullfunc_get' declared here
   struct sk_buff *ieee80211_nullfunc_get(struct ieee80211_hw *hw,
                   ^
   2 errors generated.


vim +198 drivers/net/wireless/st/cw1200/sta.c

a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  146  
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  147  
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  148  void __cw1200_cqm_bssloss_sm(struct cw1200_common *priv,
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  149  			     int init, int good, int bad)
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  150  {
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  151  	int tx = 0;
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  152  
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  153  	priv->delayed_link_loss = 0;
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  154  	cancel_work_sync(&priv->bss_params_work);
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  155  
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  156  	pr_debug("[STA] CQM BSSLOSS_SM: state: %d init %d good %d bad: %d txlock: %d uj: %d\n",
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  157  		 priv->bss_loss_state,
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  158  		 init, good, bad,
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  159  		 atomic_read(&priv->tx_lock),
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  160  		 priv->delayed_unjoin);
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  161  
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  162  	/* If we have a pending unjoin */
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  163  	if (priv->delayed_unjoin)
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  164  		return;
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  165  
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  166  	if (init) {
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  167  		queue_delayed_work(priv->workqueue,
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  168  				   &priv->bss_loss_work,
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  169  				   HZ);
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  170  		priv->bss_loss_state = 0;
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  171  
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  172  		/* Skip the confimration procedure in P2P case */
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  173  		if (!priv->vif->p2p && !atomic_read(&priv->tx_lock))
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  174  			tx = 1;
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  175  	} else if (good) {
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  176  		cancel_delayed_work_sync(&priv->bss_loss_work);
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  177  		priv->bss_loss_state = 0;
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  178  		queue_work(priv->workqueue, &priv->bss_params_work);
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  179  	} else if (bad) {
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  180  		/* XXX Should we just keep going until we time out? */
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  181  		if (priv->bss_loss_state < 3)
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  182  			tx = 1;
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  183  	} else {
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  184  		cancel_delayed_work_sync(&priv->bss_loss_work);
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  185  		priv->bss_loss_state = 0;
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  186  	}
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  187  
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  188  	/* Bypass mitigation if it's disabled */
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  189  	if (!cw1200_bssloss_mitigation)
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  190  		tx = 0;
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  191  
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  192  	/* Spit out a NULL packet to our AP if necessary */
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  193  	if (tx) {
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  194  		struct sk_buff *skb;
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  195  
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  196  		priv->bss_loss_state++;
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  197  
7b6ddeaf27eca72 drivers/net/wireless/st/cw1200/sta.c Johannes Berg  2017-11-21 @198  		skb = ieee80211_nullfunc_get(priv->hw, priv->vif, false);
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  199  		WARN_ON(!skb);
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  200  		if (skb)
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  201  			cw1200_tx(priv->hw, NULL, skb);
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  202  	}
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  203  }
a910e4a94f6923c drivers/net/wireless/cw1200/sta.c    Solomon Peachy 2013-05-24  204  

:::::: The code at line 198 was first introduced by commit
:::::: 7b6ddeaf27eca72795ceeae2f0f347db1b5f9a30 mac80211: use QoS NDP for AP probing

:::::: TO: Johannes Berg <johannes.berg@...el.com>
:::::: CC: Johannes Berg <johannes.berg@...el.com>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ