linux-kernel - Re: [PATCH v1] regmap: introduce value tracing for regmap bulk operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YxCwstzaKm7qhCWV@smile.fi.intel.com>
Date:   Thu, 1 Sep 2022 16:16:34 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Dmitry Rokosov <ddrokosov@...rdevices.ru>
Cc:     "broonie@...nel.org" <broonie@...nel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "jic23@...nel.org" <jic23@...nel.org>,
        kernel <kernel@...rdevices.ru>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] regmap: introduce value tracing for regmap bulk
 operations

On Wed, Aug 31, 2022 at 03:45:30AM +0300, Dmitry Rokosov wrote:

...

> > > +               if (val)
> > > +                       memcpy(__get_dynamic_array(buf), val, val_len);
> > 
> > I'm probably missing something, but what this condition prevents from?
> 
> In general, this condition prevents memcpy from being executed when
> tracepoint is called with a null pointed buffer.

If we got a NULL pointer here, we already in a lot of troubles.
I believe the check is not needed.

Otherwise the function prints garbage.

I will send a series to remove that and clean up the file.

-- 
With Best Regards,
Andy Shevchenko