linux-kernel - Re: [PATCH v4 1/2] lib/string_helpers: Introduce parse_int_array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2410bc5e-4278-ed69-c57a-868ec01ada21@intel.com>
Date:   Fri, 2 Sep 2022 14:47:47 +0200
From:   Cezary Rojewski <cezary.rojewski@...el.com>
To:     Amadeusz Sławiński 
        <amadeuszx.slawinski@...ux.intel.com>,
        <alsa-devel@...a-project.org>, <broonie@...nel.org>
CC:     <tiwai@...e.com>, <perex@...ex.cz>,
        <pierre-louis.bossart@...ux.intel.com>, <hdegoede@...hat.com>,
        <lgirdwood@...il.com>, <kai.vehmanen@...ux.intel.com>,
        <peter.ujfalusi@...ux.intel.com>,
        <ranjani.sridharan@...ux.intel.com>,
        <yung-chuan.liao@...ux.intel.com>, <willy@...radead.org>,
        <linux-kernel@...r.kernel.org>, <andy@...nel.org>,
        <intel-poland@...ists.intel.com>, <andy.shevchenko@...il.com>
Subject: Re: [PATCH v4 1/2] lib/string_helpers: Introduce
 parse_int_array_user()

On 2022-09-02 2:23 PM, Amadeusz Sławiński wrote:
> On 9/2/2022 2:29 PM, Cezary Rojewski wrote:

...

>> +/**
>> + * parse_int_array_user - Split string into a sequence of integers
>> + * @from:    The user space buffer to read from
>> + * @ppos:    The current position in the buffer
> 
> There is no such parameter?
> 
>> + * @count:    The maximum number of bytes to read
>> + * @tkns:    Returned pointer to sequence of integers
> 
> s/tkns/array/ ?
> 
>> + *
>> + * On success @tkns is allocated and initialized with a sequence of
> 
> ditto
> 
>> + * integers extracted from the @from plus an additional element that
>> + * begins the sequence and specifies the integers count.
>> + *
>> + * Caller takes responsibility for freeing @tkns when it is no longer
> 
> ditto
> 
>> + * needed.
>> + */
>> +int parse_int_array_user(const char __user *from, size_t count, int 
>> **array)

Ack. Will send an update shortly.


Regards,
Czarek