linux-kernel - Re: [PATCH 2/2] ARM: dts: kirkwood: lsxl: remove first ethernet port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87wnaleua8.fsf@BL-laptop>
Date:   Fri, 02 Sep 2022 16:16:15 +0200
From:   Gregory CLEMENT <gregory.clement@...tlin.com>
To:     Michael Walle <michael@...le.cc>, Andrew Lunn <andrew@...n.ch>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jason Cooper <jason@...edaemon.net>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Michael Walle <michael@...le.cc>
Subject: Re: [PATCH 2/2] ARM: dts: kirkwood: lsxl: remove first ethernet port

Michael Walle <michael@...le.cc> writes:

> Both the Linkstation LS-CHLv2 and the LS-XHL have only one ethernet
> port. This has always been wrong, i.e. the board code used to set up
> both ports, but the driver will play nice and return -ENODEV if the
> assiciated PHY is not found. Nevertheless, it is wrong. Remove it.
>
> Fixes: 876e23333511 ("ARM: kirkwood: add gigabit ethernet and mvmdio device tree nodes")
> Signed-off-by: Michael Walle <michael@...le.cc>

Applied on mvebu/dt

Thanks,

Gregory
> ---
>  arch/arm/boot/dts/kirkwood-lsxl.dtsi | 11 -----------
>  1 file changed, 11 deletions(-)
>
> diff --git a/arch/arm/boot/dts/kirkwood-lsxl.dtsi b/arch/arm/boot/dts/kirkwood-lsxl.dtsi
> index 321a40a98ed2..88b70ba1c8fe 100644
> --- a/arch/arm/boot/dts/kirkwood-lsxl.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-lsxl.dtsi
> @@ -218,22 +218,11 @@ hdd_power: regulator@2 {
>  &mdio {
>  	status = "okay";
>  
> -	ethphy0: ethernet-phy@0 {
> -		reg = <0>;
> -	};
> -
>  	ethphy1: ethernet-phy@8 {
>  		reg = <8>;
>  	};
>  };
>  
> -&eth0 {
> -	status = "okay";
> -	ethernet0-port@0 {
> -		phy-handle = <&ethphy0>;
> -	};
> -};
> -
>  &eth1 {
>  	status = "okay";
>  	ethernet1-port@0 {
> -- 
> 2.30.2
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com