linux-kernel - Re: [PATCH v5 2/2] ASoC: SOF: Remove strsplit_u32() and tokenize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 2 Sep 2022 17:25:08 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Cezary Rojewski <cezary.rojewski@...el.com>
Cc:     alsa-devel@...a-project.org, broonie@...nel.org, tiwai@...e.com,
        perex@...ex.cz, amadeuszx.slawinski@...ux.intel.com,
        pierre-louis.bossart@...ux.intel.com, hdegoede@...hat.com,
        lgirdwood@...il.com, kai.vehmanen@...ux.intel.com,
        peter.ujfalusi@...ux.intel.com, ranjani.sridharan@...ux.intel.com,
        yung-chuan.liao@...ux.intel.com, willy@...radead.org,
        linux-kernel@...r.kernel.org, andy@...nel.org,
        intel-poland@...ists.intel.com
Subject: Re: [PATCH v5 2/2] ASoC: SOF: Remove strsplit_u32() and
 tokenize_input()

On Fri, Sep 02, 2022 at 03:32:56PM +0200, Cezary Rojewski wrote:
> Make use of global integer-array parsing helper instead of the internal
> one as both serve same purpose. With that, both strsplit_u32() and
> tokenize_input() become unused so remove them.

More minor comments...

...

> +	ret = parse_int_array_user(from, count, (int **)&array);
>  	if (ret < 0)
>  		return ret;

> +	num_elems = *array;
> +	bytes = sizeof(*array) * num_elems;
> +	if (!num_elems || (bytes % sizeof(*desc))) {

!num_elems is a dup since previous already does this check.

...

> +	ret = parse_int_array_user(from, count, (int **)&array);
>  	if (ret < 0)
>  		return ret;
> +
> +	num_elems = *array;

> +	if (!num_elems) {
>  		ret = -EINVAL;
>  		goto exit;
>  	}

Ditto.

-- 
With Best Regards,
Andy Shevchenko