linux-kernel - Re: [GIT pull] objtool/urgent for v5.19-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNASL3tZ_NwNmCaovQdBaKvQf1HrFRsSMw3zrCB63wC9yKA@mail.gmail.com>
Date:   Fri, 2 Sep 2022 23:34:30 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "the arch/x86 maintainers" <x86@...nel.org>
Subject: Re: [GIT pull] objtool/urgent for v5.19-rc1

Hi Linus,

On Mon, Jun 6, 2022 at 2:14 AM Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> On Sun, Jun 5, 2022 at 2:30 AM Thomas Gleixner <tglx@...utronix.de> wrote:
> >
> > diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> > index 06400504150b..6a663b27b286 100644
> > --- a/scripts/Makefile.build
> > +++ b/scripts/Makefile.build
> > @@ -218,7 +218,7 @@ objtool_args =                                                              \
> >         $(if $(CONFIG_SLS), --sls)                                      \
> >         $(if $(CONFIG_STACK_VALIDATION), --stackval)                    \
> >         $(if $(CONFIG_HAVE_STATIC_CALL_INLINE), --static-call)          \
> > -       --uaccess                                                       \
> > +       $(if $(CONFIG_HAVE_UACCESS_VALIDATION), --uaccess)              \
> >         $(if $(linked-object), --link)                                  \
> >         $(if $(part-of-module), --module)                               \
> >         $(if $(CONFIG_GCOV_KERNEL), --no-unreachable)
>
> Since this clashed with the Kbuild cleanups I just merged, I looked at
> it and threw up in my mouth a little.
>
> Not a new problem, but can we do something like that attached, perhaps?
>
> Untested, but looks trivially obvious. FamousLastWords(tm).
>
>                   Linus

A nice idea.

I also cleaned up scripts/Makefile.vmlinux_o in a similar way,
and submitted a patch.

https://lore.kernel.org/lkml/20220902130846.654526-1-masahiroy@kernel.org/T/#u

I will send it in the next MW.


--
Best Regards
Masahiro Yamada