linux-kernel - Re: [PATCH] dt-bindings: mfd: Add missing (unevaluated|additional)Properties on child nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqJTgrSZcKNr1ky5LAXRQbj3MADMpCCYVC26rcZvzwY1Xw@mail.gmail.com>
Date:   Fri, 2 Sep 2022 09:51:07 -0500
From:   Rob Herring <robh@...nel.org>
To:     Jernej Škrabec <jernej.skrabec@...il.com>
Cc:     Lee Jones <lee@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Samuel Holland <samuel@...lland.org>,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Richard Fitzgerald <rf@...nsource.cirrus.com>,
        Tim Harvey <tharvey@...eworks.com>,
        Robert Jones <rjones@...eworks.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Heiko Stuebner <heiko@...ech.de>,
        Fabrice Gasnier <fabrice.gasnier@...s.st.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Maxime Ripard <mripard@...nel.org>,
        - <patches@...nsource.cirrus.com>,
        Steve Twiss <stwiss.opensource@...semi.com>,
        Chris Zhong <zyw@...k-chips.com>,
        Zhang Qing <zhangqing@...k-chips.com>,
        Alistair Francis <alistair@...stair23.me>,
        Amelie Delaunay <amelie.delaunay@...s.st.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Renner Berthing <kernel@...il.dk>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        devicetree@...r.kernel.org,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-sunxi@...ts.linux.dev,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        "moderated list:ARM/STM32 ARCHITECTURE" 
        <linux-stm32@...md-mailman.stormreply.com>
Subject: Re: [PATCH] dt-bindings: mfd: Add missing (unevaluated|additional)Properties
 on child nodes

On Thu, Aug 25, 2022 at 3:49 PM Jernej Škrabec <jernej.skrabec@...il.com> wrote:
>
> Dne torek, 23. avgust 2022 ob 16:56:35 CEST je Rob Herring napisal(a):
> > In order to ensure only documented properties are present, node schemas
> > must have unevaluatedProperties or additionalProperties set to false
> > (typically).
> >
> > Signed-off-by: Rob Herring <robh@...nel.org>
> > ---
> >  .../mfd/allwinner,sun6i-a31-prcm.yaml         | 40 +++++++++++++++++++
> >  .../mfd/allwinner,sun8i-a23-prcm.yaml         | 10 +++++
> >  .../bindings/mfd/cirrus,lochnagar.yaml        |  5 +++
> >  .../devicetree/bindings/mfd/dlg,da9063.yaml   |  7 ++--
> >  .../bindings/mfd/gateworks-gsc.yaml           |  5 ++-
> >  .../bindings/mfd/maxim,max14577.yaml          |  1 +
> >  .../bindings/mfd/maxim,max77843.yaml          |  1 +
> >  .../bindings/mfd/rockchip,rk817.yaml          |  2 +
> >  .../bindings/mfd/silergy,sy7636a.yaml         |  1 +
> >  .../bindings/mfd/st,stm32-lptimer.yaml        |  4 ++
> >  .../bindings/mfd/st,stm32-timers.yaml         |  3 ++
> >  .../devicetree/bindings/mfd/st,stmfx.yaml     |  1 +
> >  .../bindings/mfd/stericsson,ab8500.yaml       | 22 ++++++++++
> >  .../devicetree/bindings/mfd/ti,tps65086.yaml  |  1 +
> >  .../bindings/mfd/x-powers,axp152.yaml         |  1 +
> >  15 files changed, 100 insertions(+), 4 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/mfd/allwinner,sun6i-a31-prcm.yaml
> > b/Documentation/devicetree/bindings/mfd/allwinner,sun6i-a31-prcm.yaml index
> > d131759ccaf3..021d33cb3dd6 100644
> > --- a/Documentation/devicetree/bindings/mfd/allwinner,sun6i-a31-prcm.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/allwinner,sun6i-a31-prcm.yaml
> > @@ -22,6 +22,7 @@ properties:
> >  patternProperties:
> >    "^.*_(clk|rst)$":
> >      type: object
> > +    unevaluatedProperties: false
> >
> >      properties:
> >        compatible:
> > @@ -34,6 +35,45 @@ patternProperties:
> >            - fixed-factor-clock
> >
> >      allOf:
> > +      - if:
> > +          properties:
> > +            compatible:
> > +              contains:
> > +                const: fixed-factor-clock
> > +
> > +        then:
> > +          $ref: /schemas/clock/fixed-factor-clock.yaml#
> > +
> > +      - if:
> > +          properties:
> > +            compatible:
> > +              contains:
> > +                const: allwinner,sun4i-a10-mod0-clk
> > +
> > +        then:
> > +          properties:
> > +            "#clock-cells":
> > +              const: 0
> > +
> > +            # Already checked in the main schema
> > +            compatible: true
> > +
> > +            clocks:
> > +              maxItems: 2
>
> Last time node with allwinner,sun4i-a10-mod0-clk compatible was used, it had 3
> clocks. See:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/
> arm/boot/dts/sun4i-a10.dtsi?id=f18698e1c66338b902de386e4ad97b8b1b9d999d#n406

Humm, we already have constraints in
bindings/clock/allwinner,sun4i-a10-mod0-clk.yaml. I'll just make it
'clocks: true' here instead.

Rob