[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <YxIdeiL0iOsN3zv8@casper.infradead.org>
Date: Fri, 2 Sep 2022 16:12:58 +0100
From: Matthew Wilcox <willy@...radead.org>
To: Yury Norov <yury.norov@...il.com>
Cc: linux-kernel@...r.kernel.org,
Andrew Morton <akpm@...ux-foundation.org>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
David Howells <dhowells@...hat.com>,
Ingo Molnar <mingo@...nel.org>,
Geert Uytterhoeven <geert@...ux-m68k.org>,
Jonathan Corbet <corbet@....net>,
"Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
NeilBrown <neilb@...e.de>,
Rasmus Villemoes <linux@...musvillemoes.dk>,
Russell King <linux@...linux.org.uk>,
Vlastimil Babka <vbabka@...e.cz>,
William Kucharski <william.kucharski@...cle.com>,
linux-doc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mm@...ck.org
Subject: Re: [PATCH 08/10] headers/deps: mm: Split <linux/gfp_types.h> out of
<linux/gfp.h>
On Thu, Sep 01, 2022 at 07:10:09PM -0700, Yury Norov wrote:
> On Thu, Sep 01, 2022 at 09:43:13PM +0100, Matthew Wilcox wrote:
> > On Wed, Jul 06, 2022 at 10:42:51AM -0700, Yury Norov wrote:
> > > From: Ingo Molnar <mingo@...nel.org>
> > >
> > > This is a much smaller header.
> > >
> > > Signed-off-by: Ingo Molnar <mingo@...nel.org>
> > > Signed-off-by: Yury Norov <yury.norov@...il.com>
> > > ---
> > > include/linux/gfp.h | 345 +------------------------------------
> > > include/linux/gfp_types.h | 348 ++++++++++++++++++++++++++++++++++++++
> > > 2 files changed, 350 insertions(+), 343 deletions(-)
> >
> > You move a lot of kernel-doc. Where do you change the rst files?
>
> Ingo - nowhere. So I did it in the next patch:
>
> 7343f2b0db4961d ("headers/deps: mm: align MANITAINERS and Docs with new
> gfp.h structure")
That's not the right way to do it. Don't merge a patch with bugs and
then fix it up in the next patch. Just fix the patch. This is covered
in Documentation/process/.
Powered by blists - more mailing lists