linux-kernel - Re: [PATCH 4/4] riscv: check for kernel config option in t-head memory types errata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10808758.0AQdONaE2F@diego>
Date:   Fri, 02 Sep 2022 17:17:01 +0200
From:   Heiko Stübner <heiko@...ech.de>
To:     guoren@...nel.org, Conor.Dooley@...rochip.com
Cc:     paul.walmsley@...ive.com, palmer@...belt.com,
        aou@...s.berkeley.edu, apatel@...tanamicro.com,
        atishp@...osinc.com, linux-riscv@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] riscv: check for kernel config option in t-head memory types errata

Am Freitag, 2. September 2022, 11:33:27 CEST schrieb Conor.Dooley@...rochip.com:
> On 02/09/2022 02:06, Guo Ren wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > 
> > Is it a Fixes?
> 
> Looks like one to me, seems a fixes tag would be good to
> have here... Either way:
> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

The alternative itself also is protected by the kconfig-option,
so even if probe says "yes", nothing will be patched when
CONFIG_ERRATA_THEAD_PBMT is not enabled.

So for the memory-types it's more a change to keep it consistent
with the other extensions. But I guess we can add the fixes-tag
anyway, as it makes sure that doesn't get copy-pasted somewhere
else :-)


Heiko



> > 
> > On Fri, Sep 2, 2022 at 6:28 AM Heiko Stuebner <heiko@...ech.de> wrote:
> >>
> >> The t-head variant of page-based memory types should also check first
> >> for the enabled kernel config option.
> >>
> >> Signed-off-by: Heiko Stuebner <heiko@...ech.de>
> >> ---
> >>   arch/riscv/errata/thead/errata.c | 3 +++
> >>   1 file changed, 3 insertions(+)
> >>
> >> diff --git a/arch/riscv/errata/thead/errata.c b/arch/riscv/errata/thead/errata.c
> >> index a6f4bd8ccf3f..902e12452821 100644
> >> --- a/arch/riscv/errata/thead/errata.c
> >> +++ b/arch/riscv/errata/thead/errata.c
> >> @@ -17,6 +17,9 @@
> >>   static bool errata_probe_pbmt(unsigned int stage,
> >>                                unsigned long arch_id, unsigned long impid)
> >>   {
> >> +       if (!IS_ENABLED(CONFIG_ERRATA_THEAD_PBMT))
> >> +               return false;
> >> +
> >>          if (arch_id != 0 || impid != 0)
> >>                  return false;
> >>
> >> --
> >> 2.35.1
> >>
> > 
> > 
> > --
> > Best Regards
> >   Guo Ren
> 
>