linux-kernel - Re: [PATCH 2/3] iio: temperature: mlx90632 Read sampling frequency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VeyR-0E+7rs4h-KfPHcef5LGg0vt7f5Pxjfij6vmmLQCA@mail.gmail.com>
Date:   Fri, 2 Sep 2022 18:30:06 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Crt Mori <cmo@...exis.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] iio: temperature: mlx90632 Read sampling frequency

On Fri, Sep 2, 2022 at 4:13 PM <cmo@...exis.com> wrote:
>
> From: Crt Mori <cmo@...exis.com>
>
> Allow user to read sensor sampling frequency to better plan the

the user
...or...
users

> application measurement requests.

...

> +       int ret;
> +       unsigned int meas1;

Reversed xmas tree order?

...

> +static const int mlx90632_freqs[8][2] = { {0, 500000}, {1, 0}, {2, 0}, {4, 0},
> +                                         {8, 0}, {16, 0}, {32, 0}, {64, 0} };

Can we use better indentation? Also one of the sizes in the definition
can be dropped.

-- 
With Best Regards,
Andy Shevchenko