linux-kernel - Re: [PATCH] perf stat: Fix L2 Topdown metrics disappear for raw events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YxI1Eq1XzHf8O4L2@kernel.org>
Date:   Fri, 2 Sep 2022 13:53:38 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     zhengjun.xing@...ux.intel.com
Cc:     peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...el.com, jolsa@...nel.org,
        namhyung@...nel.org, linux-kernel@...r.kernel.org,
        linux-perf-users@...r.kernel.org, irogers@...gle.com,
        ak@...ux.intel.com, kan.liang@...ux.intel.com
Subject: Re: [PATCH] perf stat: Fix L2 Topdown metrics disappear for raw
 events

Em Fri, Aug 26, 2022 at 10:00:57PM +0800, zhengjun.xing@...ux.intel.com escreveu:
> From: Zhengjun Xing <zhengjun.xing@...ux.intel.com>
> 
> In perf/Documentation/perf-stat.txt, for "--td-level" the default "0" means
> the max level that the current hardware support. So we need initialize the
> stat_config.topdown_level to TOPDOWN_MAX_LEVEL when “--td-level=0” or no
> “--td-level” option. Otherwise, for the hardware with a max level is 2, the
> 2nd level metrics disappear for raw events in this case. The issue cannot
> be observed for the perf stat default or "--topdown" options. This commit
> fixes the raw events issue and removes the duplicated code for the perf
> stat default.

Thanks, applied, sorry for the delay.

- Arnaldo