[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <04151f8b-5722-b5a0-a4ab-4958f55b8dec@microchip.com>
Date: Fri, 2 Sep 2022 06:27:24 +0000
From: <Conor.Dooley@...rochip.com>
To: <cristian.ciocaltea@...labora.com>, <robh+dt@...nel.org>,
<krzysztof.kozlowski+dt@...aro.org>, <paul.walmsley@...ive.com>,
<palmer@...belt.com>, <aou@...s.berkeley.edu>,
<michael.zhu@...rfivetech.com>, <drew@...gleboard.org>,
<kernel@...il.dk>
CC: <devicetree@...r.kernel.org>, <linux-riscv@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>, <kernel@...labora.com>
Subject: Re: [PATCH 0/3] Enable initial support for StarFive VisionFive V1 SBC
On 01/09/2022 23:42, Cristian Ciocaltea wrote:
> [You don't often get email from cristian.ciocaltea@...labora.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> The StarFive VisionFive V1 SBC [1] is similar with the already supported
> BeagleV Starlight Beta board, both being based on the StarFive JH7100 SoC.
>
> In addition to documenting the necessary compatibles, this patch series
> moves most of the content from jh7100-beaglev-starlight.dts to a new file
> jh7100-common.dtsi, to be shared between the two boards.
>
> No other changes are required in order to successfully boot the board.
Gave it a go this morning, dts stuff itself looks good to me. No new
warnings, although that's to be expected, & boots fine.
I know that most jn7100 stuff is not really wanted upstream, but I'd
say that the minimal vision5 dts is an exception to that, so with the
one comment on patch 1 resolved:
Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
Thanks,
Conor.
>
> [1] https://github.com/starfive-tech/VisionFive
>
> Cristian Ciocaltea (3):
> dt-bindings: riscv: starfive: Add StarFive VisionFive V1 board
> riscv: dts: starfive: Add common DT for JH7100 based boards
> riscv: dts: starfive: Add StarFive VisionFive V1 device tree
>
> .../devicetree/bindings/riscv/starfive.yaml | 3 +
> arch/riscv/boot/dts/starfive/Makefile | 2 +-
> .../dts/starfive/jh7100-beaglev-starlight.dts | 153 +----------------
> .../boot/dts/starfive/jh7100-common.dtsi | 161 ++++++++++++++++++
> .../jh7100-starfive-visionfive-v1.dts | 20 +++
> 5 files changed, 186 insertions(+), 153 deletions(-)
> create mode 100644 arch/riscv/boot/dts/starfive/jh7100-common.dtsi
> create mode 100644 arch/riscv/boot/dts/starfive/jh7100-starfive-visionfive-v1.dts
>
> --
> 2.37.2
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
Powered by blists - more mailing lists