linux-kernel - Re: [PATCH linux-next] drm/dp_helper: Remove the unneeded result variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <877d2mfala.fsf@intel.com>
Date:   Fri, 02 Sep 2022 11:24:01 +0300
From:   Jani Nikula <jani.nikula@...el.com>
To:     cgel.zte@...il.com, airlied@...ux.ie
Cc:     daniel@...ll.ch, ville.syrjala@...ux.intel.com, lyude@...hat.com,
        tzimmermann@...e.de, imre.deak@...el.com,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        zhang songyi <zhang.songyi@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] drm/dp_helper: Remove the unneeded result
 variable

On Fri, 02 Sep 2022, cgel.zte@...il.com wrote:
> From: zhang songyi <zhang.songyi@....com.cn>
>
> Return the drm_dp_dpcd_writeb() directly instead of storing it in another
> redundant variable.

Please just *stop* sending changes like this. See for example [1].

What's most offending to me is that I've replied to a lot of patches
from you, but I've *never* *even* *once* received a reply back on my
reviews.

If you want to participate in creating a better kernel, then please
*participate*. Just throwing random cleanup patches in our general
direction with one-way communication is not helping.

I'm seriously considering just ignoring *all* patches from you.


BR,
Jani.



[1] https://lore.kernel.org/r/8735dcepcv.fsf@intel.com

>
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: zhang songyi <zhang.songyi@....com.cn>
> ---
>  drivers/gpu/drm/display/drm_dp_helper.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c
> index 92990a3d577a..09b282b704fa 100644
> --- a/drivers/gpu/drm/display/drm_dp_helper.c
> +++ b/drivers/gpu/drm/display/drm_dp_helper.c
> @@ -2925,16 +2925,13 @@ EXPORT_SYMBOL(drm_dp_get_pcon_max_frl_bw);
>   */
>  int drm_dp_pcon_frl_prepare(struct drm_dp_aux *aux, bool enable_frl_ready_hpd)
>  {
> -	int ret;
>  	u8 buf = DP_PCON_ENABLE_SOURCE_CTL_MODE |
>  		 DP_PCON_ENABLE_LINK_FRL_MODE;
>  
>  	if (enable_frl_ready_hpd)
>  		buf |= DP_PCON_ENABLE_HPD_READY;
>  
> -	ret = drm_dp_dpcd_writeb(aux, DP_PCON_HDMI_LINK_CONFIG_1, buf);
> -
> -	return ret;
> +	return drm_dp_dpcd_writeb(aux, DP_PCON_HDMI_LINK_CONFIG_1, buf);
>  }
>  EXPORT_SYMBOL(drm_dp_pcon_frl_prepare);

-- 
Jani Nikula, Intel Open Source Graphics Center