linux-kernel - Re: [PATCH linux-next] Driver: r8188eu: Remove the unneeded result variable Return 0 instead of storing it in another redundant variable.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 2 Sep 2022 11:54:46 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     cgel.zte@...il.com
Cc:     Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        paskripkin@...il.com, gregkh@...uxfoundation.org,
        straube.linux@...il.com, martin@...ser.cx, lu.fengchang@....com.cn,
        makvihas@...il.com, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, Zeal-Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] Driver: r8188eu: Remove the unneeded result
 variable Return 0 instead of storing it in another redundant variable.

On Fri, Sep 02, 2022 at 03:26:28AM +0000, cgel.zte@...il.com wrote:
> From: lufengchang <lu.fengchang@....com.cn>
> 
> Reported-by: Zeal-Robot <zealci@....com.cn>
> Signed-off-by: lufengchang <lu.fengchang@....com.cn>
> ---

There is a lot wrong with the format of this patch.
1) The subsystem prefix
2) The blank line after the subject
3) Line wrapping at 75 chars
4) Your name is not capitalized
5) Greg doesn't like Zeal-Robot tags.

regards,
dan carpenter