| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202209021600.EXVMBEGf-lkp@intel.com>
Date: Fri, 2 Sep 2022 17:14:12 +0800
From: kernel test robot <lkp@...el.com>
To: hezhongkun <hezhongkun.hzk@...edance.com>, tj@...nel.org,
lizefan.x@...edance.com, hannes@...xchg.org
Cc: kbuild-all@...ts.01.org, cgroups@...r.kernel.org,
linux-kernel@...r.kernel.org,
Zhongkun He <hezhongkun.hzk@...edance.com>
Subject: Re: [PATCH] cgroup/cpuset: Add a new isolated mems.policy type.
Hi hezhongkun,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tip/sched/core]
[also build test WARNING on linus/master v6.0-rc3 next-20220901]
[cannot apply to tj-cgroup/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/hezhongkun/cgroup-cpuset-Add-a-new-isolated-mems-policy-type/20220902-143512
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 53aa930dc4bae6aa269951bd37103083145d6691
config: mips-allyesconfig
compiler: mips-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/7b7fbf5ae59ebc703a8d545fabd305563c0f42f6
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review hezhongkun/cgroup-cpuset-Add-a-new-isolated-mems-policy-type/20220902-143512
git checkout 7b7fbf5ae59ebc703a8d545fabd305563c0f42f6
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash kernel/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/sched.h:22,
from include/linux/ratelimit.h:6,
from include/linux/dev_printk.h:16,
from include/linux/device.h:15,
from include/linux/node.h:18,
from include/linux/cpu.h:17,
from kernel/cgroup/cpuset.c:25:
kernel/cgroup/cpuset.c: In function 'update_nodemasks_hier':
kernel/cgroup/cpuset.c:1867:54: error: 'struct mempolicy' has no member named 'w'
1867 | cp->mempolicy->w.user_nodemask);
| ^~
include/linux/nodemask.h:163:56: note: in definition of macro 'nodes_and'
163 | __nodes_and(&(dst), &(src1), &(src2), MAX_NUMNODES)
| ^~~~
kernel/cgroup/cpuset.c: In function 'cpuset_change_task_cs_mpol':
kernel/cgroup/cpuset.c:2477:12: error: 'struct task_struct' has no member named 'il_prev'
2477 | tsk->il_prev = 0;
| ^~
kernel/cgroup/cpuset.c: In function 'cpuset_mpol_write':
kernel/cgroup/cpuset.c:2525:63: error: 'struct mempolicy' has no member named 'w'
2525 | nodes_and(cs_allowed, cs->effective_mems, mpol->w.user_nodemask);
| ^~
include/linux/nodemask.h:163:56: note: in definition of macro 'nodes_and'
163 | __nodes_and(&(dst), &(src1), &(src2), MAX_NUMNODES)
| ^~~~
kernel/cgroup/cpuset.c: In function 'cpuset_mpol_show':
kernel/cgroup/cpuset.c:2558:26: error: 'struct mempolicy' has no member named 'mode'
2558 | if (!mpol || mpol->mode == MPOL_DEFAULT)
| ^~
kernel/cgroup/cpuset.c:2561:9: error: implicit declaration of function 'mpol_to_str' [-Werror=implicit-function-declaration]
2561 | mpol_to_str(buffer, sizeof(buffer), mpol);
| ^~~~~~~~~~~
kernel/cgroup/cpuset.c: In function 'cpuset_css_alloc':
kernel/cgroup/cpuset.c:2981:15: error: implicit declaration of function 'mpol_dup'; did you mean 'mpol_put'? [-Werror=implicit-function-declaration]
2981 | new = mpol_dup(pcs->mempolicy);
| ^~~~~~~~
| mpol_put
>> kernel/cgroup/cpuset.c:2981:13: warning: assignment to 'struct mempolicy *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
2981 | new = mpol_dup(pcs->mempolicy);
| ^
cc1: some warnings being treated as errors
vim +2981 kernel/cgroup/cpuset.c
2948
2949
2950 /*
2951 * cpuset_css_alloc - allocate a cpuset css
2952 * cgrp: control group that the new cpuset will be part of
2953 */
2954
2955 static struct cgroup_subsys_state *
2956 cpuset_css_alloc(struct cgroup_subsys_state *parent_css)
2957 {
2958 struct cpuset *cs, *pcs = css_cs(parent_css);
2959 struct mempolicy *new;
2960
2961 if (!parent_css)
2962 return &top_cpuset.css;
2963
2964 cs = kzalloc(sizeof(*cs), GFP_KERNEL);
2965 if (!cs)
2966 return ERR_PTR(-ENOMEM);
2967
2968 if (alloc_cpumasks(cs, NULL)) {
2969 kfree(cs);
2970 return ERR_PTR(-ENOMEM);
2971 }
2972
2973 __set_bit(CS_SCHED_LOAD_BALANCE, &cs->flags);
2974 nodes_clear(cs->mems_allowed);
2975 nodes_clear(cs->effective_mems);
2976 fmeter_init(&cs->fmeter);
2977 cs->relax_domain_level = -1;
2978
2979 /*Inherit mempolicy from parent.*/
2980 spin_lock_irq(&callback_lock);
> 2981 new = mpol_dup(pcs->mempolicy);
2982
2983 if (IS_ERR(new))
2984 new = NULL;
2985
2986 cs->mempolicy = new;
2987 spin_unlock_irq(&callback_lock);
2988
2989 /* Set CS_MEMORY_MIGRATE for default hierarchy */
2990 if (cgroup_subsys_on_dfl(cpuset_cgrp_subsys))
2991 __set_bit(CS_MEMORY_MIGRATE, &cs->flags);
2992
2993 return &cs->css;
2994 }
2995
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (323891 bytes)
Powered by blists - more mailing lists