linux-kernel - Re: [PATCH v2 5/5] bus: hisi_lpc: Use platform_device_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ce2312ef-fffa-2467-f6b3-98ac31244065@huawei.com>
Date:   Fri, 2 Sep 2022 10:35:45 +0100
From:   John Garry <john.garry@...wei.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     "xuwei (O)" <xuwei5@...ilicon.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Linuxarm <linuxarm@...wei.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        SoC Team <soc@...nel.org>,
        Yang Yingliang <yangyingliang@...wei.com>
Subject: Re: [PATCH v2 5/5] bus: hisi_lpc: Use platform_device_register_full()

On 02/09/2022 10:21, Andy Shevchenko wrote:
>> Reviewed-by: Andy Shevchenko<andy.shevchenko@...il.com>
> Too fast to give a tag, see below (keep tag if addressing it)

thanks

> 
> ...
> 
>>> -       pdev = platform_device_alloc(cell->name, PLATFORM_DEVID_AUTO);
>>> +       pdev = platform_device_register_full(cell->pdevinfo);
>>>          if (!pdev)
>>>                  return -ENOMEM;
> As per kernel doc:
>   * Returns &struct platform_device pointer on success, or ERR_PTR() on error.

ah, right, I thought that I got that correct....

John