linux-kernel - RE: [char-misc:char-misc-testing 20/24] drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c:87:52: error: 'PCI_IRQ_ALL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BN8PR11MB3668A7660CC7810239885F21E97A9@BN8PR11MB3668.namprd11.prod.outlook.com>
Date:   Fri, 2 Sep 2022 09:54:44 +0000
From:   <Kumaravel.Thiagarajan@...rochip.com>
To:     <gregkh@...uxfoundation.org>
CC:     <lkp@...el.com>, <kbuild-all@...ts.01.org>,
        <linux-kernel@...r.kernel.org>
Subject: RE: [char-misc:char-misc-testing 20/24]
 drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c:87:52: error:
 'PCI_IRQ_ALL_TYPES' undeclared

> -----Original Message-----
> From: Greg KH <gregkh@...uxfoundation.org>
> Sent: Friday, September 2, 2022 2:22 PM
> To: Kumaravel Thiagarajan - I21417 <Kumaravel.Thiagarajan@...rochip.com>
> Cc: lkp@...el.com; kbuild-all@...ts.01.org; linux-kernel@...r.kernel.org
> Subject: Re: [char-misc:char-misc-testing 20/24]
> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c:87:52: error:
> 'PCI_IRQ_ALL_TYPES' undeclared
> 
> On Fri, Sep 02, 2022 at 08:30:22AM +0000,
> Kumaravel.Thiagarajan@...rochip.com wrote:
> >
> >
> > > -----Original Message-----
> > > From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > > Sent: Friday, September 2, 2022 12:33 PM
> > > To: kernel test robot <lkp@...el.com>; Kumaravel Thiagarajan -
> > > I21417 <Kumaravel.Thiagarajan@...rochip.com>;
> > > kbuild-all@...ts.01.org; linux- kernel@...r.kernel.org
> > > Subject: Re: [char-misc:char-misc-testing 20/24]
> > > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c:87:52: error:
> > > 'PCI_IRQ_ALL_TYPES' undeclared
> > >
> > >
> > > On Fri, Sep 02, 2022 at 06:13:10AM +0800, kernel test robot wrote:
> > > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-
> > > misc.git char-misc-testing
> > > > head:   51ea3f9e9017b47c15b37a200d8e81e36a169b70
> > > > commit: 3f359bf61b6f65be474fbcdf557cd412f19d0f1d [20/24] misc:
> > > microchip: pci1xxxx: load auxiliary bus driver for the PIO function
> > > in the multi- function endpoint of pci1xxxx device.
> > > > config: sh-allmodconfig
> > > > (https://download.01.org/0day-
> > > ci/archive/20220902/202209020641.mPiacQE
> > > > P-lkp@...el.com/config)
> > > > compiler: sh4-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1
> > > > build):
> > > >         wget https://raw.githubusercontent.com/intel/lkp-
> > > tests/master/sbin/make.cross -O ~/bin/make.cross
> > > >         chmod +x ~/bin/make.cross
> > > >         #
> > > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-
> > > misc.git/commit/?id=3f359bf61b6f65be474fbcdf557cd412f19d0f1d
> > > >         git remote add char-misc
> > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
> > > >         git fetch --no-tags char-misc char-misc-testing
> > > >         git checkout 3f359bf61b6f65be474fbcdf557cd412f19d0f1d
> > > >         # save the config file
> > > >         mkdir build_dir && cp config build_dir/.config
> > > >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0
> > > > make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash
> > > > drivers/misc/mchp_pci1xxxx/
> > > >
> > > > If you fix the issue, kindly add following tag where applicable
> > > > Reported-by: kernel test robot <lkp@...el.com>
> > > >
> > > > All error/warnings (new ones prefixed by >>):
> > > >
> > > >    drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c: In function
> > > 'gp_aux_bus_probe':
> > > > >> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c:87:52: error:
> > > > >> 'PCI_IRQ_ALL_TYPES' undeclared (first use in this function)
> > > >       87 |         retval = pci_alloc_irq_vectors(pdev, 1, 1,
> PCI_IRQ_ALL_TYPES);
> > > >          |                                                    ^~~~~~~~~~~~~~~~~
> > >
> > > Odd.
> > >
> > > Ah, the driver needs to have a "depends on PCI" for the Kconfig file.
> > >
> > > Kumaravel, can you send an add-on patch for this issue with the
> > > proper "Reported-by:" line as asked for above?
> > Greg, for the add-on patch, can I modify only the KConfig file which
> > you can apply to commit id: 3f359bf61b6f65be474fbcdf557cd412f19d0f1d of
> char-misc-testing?
> 
> Yes, I can merge them together.
Greg, I have sent the patch. Please apply and let me know.

Thank You.

Regards,
Kumaravel