[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220902110007.GA100460@dev-dsk-mheyne-1b-c1362c4d.eu-west-1.amazon.com>
Date: Fri, 2 Sep 2022 11:00:07 +0000
From: Maximilian Heyne <mheyne@...zon.de>
To: SeongJae Park <sj@...nel.org>
CC: <jgross@...e.com>, <roger.pau@...rix.com>,
<marmarek@...isiblethingslab.com>,
<xen-devel@...ts.xenproject.org>, <axboe@...nel.dk>,
<ptyadav@...zon.de>, <linux-block@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 0/3] xen-blk{front, back}: Fix the broken semantic and
flow of feature-persistent
On Wed, Aug 31, 2022 at 04:58:21PM +0000, SeongJae Park wrote:
> Changes from v1
> (https://lore.kernel.org/xen-devel/20220825161511.94922-1-sj@kernel.org/)
> - Fix the wrong feature_persistent caching position of blkfront
> - Set blkfront's feature_persistent field setting with simple '&&'
> instead of 'if' (Pratyush Yadav)
>
> This patchset fixes misuse of the 'feature-persistent' advertisement
> semantic (patches 1 and 2), and the wrong timing of the
> 'feature_persistent' value caching, which made persistent grants feature
> always disabled.
>
> SeongJae Park (3):
> xen-blkback: Advertise feature-persistent as user requested
> xen-blkfront: Advertise feature-persistent as user requested
> xen-blkfront: Cache feature_persistent value before advertisement
>
> drivers/block/xen-blkback/common.h | 3 +++
> drivers/block/xen-blkback/xenbus.c | 6 ++++--
> drivers/block/xen-blkfront.c | 20 ++++++++++++--------
> 3 files changed, 19 insertions(+), 10 deletions(-)
>
> --
> 2.25.1
>
I've tested this patch series in the following ways:
* Only applied the blkback patch but not the blkfront patches
* Only applied the blkfront patches but not the blkback patch
* Applied both
All scenarios worked, so
Tested-by: Maximilian Heyne <mheyne@...zon.de>
Actually I also wanted to test changing feature_persistent and try reconnecting
but I don't know how this is done. If anyone has a pointer here, I could test
that as well.
Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879
Powered by blists - more mailing lists