linux-kernel - Re: [PATCH v2] checkpatch: Handle FILE pointer type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7591cea9e718f6abfee14f08e97937b1c2722dd6.camel@perches.com>
Date:   Fri, 02 Sep 2022 05:00:18 -0700
From:   Joe Perches <joe@...ches.com>
To:     Mickaël Salaün <mic@...ikod.net>,
        Andy Whitcroft <apw@...onical.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     Dwaipayan Ray <dwaipayanray1@...il.com>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Shuah Khan <shuah@...nel.org>, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v2] checkpatch: Handle FILE pointer type

On Fri, 2022-09-02 at 13:19 +0200, Mickaël Salaün wrote:
> When using a "FILE *" type, checkpatch considers this an error:
>   ERROR: need consistent spacing around '*' (ctx:WxV)
>   #32: FILE: f.c:8:
>   +static void a(FILE *const b)
[]
> Signed-off-by: Mickaël Salaün <mic@...ikod.net>

Acked-by: Joe Perches <joe@...ches.com>

> Link: https://lore.kernel.org/r/20220902111923.1488671-1-mic@digikod.net
> ---
> Changes since v1:
> https://lore.kernel.org/r/20220901145948.1456353-1-mic@digikod.net
> * Remove the FIXTURE_{DATA,VARIANT}() comments.
> * Improve commit description.
> ---
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -576,10 +576,14 @@ our $typeKernelTypedefs = qr{(?x:
>  	(?:__)?(?:u|s|be|le)(?:8|16|32|64)|
>  	atomic_t
>  )};
> +our $typeStdioTypedefs = qr{(?x:
> +	FILE
> +)};
>  our $typeTypedefs = qr{(?x:
>  	$typeC99Typedefs\b|
>  	$typeOtherOSTypedefs\b|
> -	$typeKernelTypedefs\b
> +	$typeKernelTypedefs\b|
> +	$typeStdioTypedefs\b
>  )};
>  
>  our $zero_initializer = qr{(?:(?:0[xX])?0+$Int_type?|NULL|false)\b};
> 
> base-commit: b90cb1053190353cc30f0fef0ef1f378ccc063c5