linux-kernel - Re: [PATCH v12 12/13] dm: introduce DM_EMULATED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96f90e1d-aa0f-1c76-bfc9-a87e978ad655@samsung.com>
Date:   Fri, 2 Sep 2022 14:02:02 +0200
From:   Pankaj Raghav <p.raghav@...sung.com>
To:     Mike Snitzer <snitzer@...hat.com>
CC:     <agk@...hat.com>, <snitzer@...nel.org>, <axboe@...nel.dk>,
        <damien.lemoal@...nsource.wdc.com>, <hch@....de>,
        <pankydev8@...il.com>, <Johannes.Thumshirn@....com>,
        <linux-block@...r.kernel.org>, <dm-devel@...hat.com>,
        <hare@...e.de>, <jaegeuk@...nel.org>,
        <linux-kernel@...r.kernel.org>, <matias.bjorling@....com>,
        <gost.dev@...sung.com>, <bvanassche@....org>,
        <linux-nvme@...ts.infradead.org>
Subject: Re: [PATCH v12 12/13] dm: introduce DM_EMULATED_ZONES target type

On 2022-09-02 02:28, Mike Snitzer wrote:
> On Tue, Aug 23 2022 at  8:18P -0400,
> Pankaj Raghav <p.raghav@...sung.com> wrote:
> 
>> Introduce a new target type DM_EMULATED_ZONES for targets with
>> a different number of sectors per zone (aka zone size) than the underlying
>> device zone size.
>>
>> This target type is introduced as the existing zoned targets assume
>> that the target and the underlying device have the same zone size.
>> The new target: dm-po2zone will use this new target
>> type as it emulates the zone boundary that is different from the
>> underlying zoned device.
>>
>> Signed-off-by: Pankaj Raghav <p.raghav@...sung.com>
>> Reviewed-by: Damien Le Moal <damien.lemoal@...nsource.wdc.com>
> 
> This patch's use of "target type" jargon isn't valid. 
> 
> Please say "target feature flag" and rename DM_EMULATED_ZONES to
> DM_TARGET_EMULATED_ZONES in the subject and header.
> Good catch. I will fix it up for the next version.
> But, with those fixed:
> 
> Signed-off-by: Mike Snitzer <snitzer@...nel.org>
> 
You mean <Reviewed-By> ? :)
> (fyi, I'll review patch 13, the dm-po2zone target, tomorrow)
> 
Thanks.