linux-kernel - Re: [GIT PULL] Driver core fixes for 6.0-rc4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YxL3W3Sb0AMMt01T@kroah.com>
Date:   Sat, 3 Sep 2022 08:42:35 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Saravana Kannan <saravanak@...gle.com>
Subject: Re: [GIT PULL] Driver core fixes for 6.0-rc4

On Fri, Sep 02, 2022 at 11:02:00AM -0700, Linus Torvalds wrote:
> On Fri, Sep 2, 2022 at 8:31 AM Greg KH <gregkh@...uxfoundation.org> wrote:
> >
> >   git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git tags/driver-core-6.0-rc4
> 
> Entirely unrelated to this pull request, but since the diffstat made
> that "drivers/base/dd.c" file stand out, I tried to look at what the
> history of that odd name is.
> 
> And it's not obvious to me.
> 
> Very strange filename. Should it perhaps be named "device.c" or
> "probe.c" or something more descriptive?
> 
> Not a huge deal, more of a passing thought inspired by that diffstat.

I think Pat named it and I always think of it as "device vs. driver".c
as it handles all of the device and driver interactions between binding
and unbinding and other fun logic there.  I'm all for a new name if
anyone has any ideas, "probe.c" is sane, but it also handles disconnect
logic.  "core.c" already has lots of device functions, so renaming it to
"device.c" would be confusing.  I don't know...

Yeah, in digging, Pat did this in commit 07e4a3e27fe4 ("[PATCH] Move
device/driver code to drivers/base/dd.c") way back in 2005 to get code
out of drivers/base/bus.c.

Naming is hard :)

greg k-h