linux-kernel - RE: [char-misc:char-misc-testing 20/24] kismet: WARNING: unmet direct dependencies detected for GPIOLIB_IRQCHIP when selected by GP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN8PR11MB3668BC26BC1B17B09A888271E97D9@BN8PR11MB3668.namprd11.prod.outlook.com>
Date:   Sat, 3 Sep 2022 10:21:31 +0000
From:   <Kumaravel.Thiagarajan@...rochip.com>
To:     <gregkh@...uxfoundation.org>, <lkp@...el.com>, <paul@...zz.com>,
        <fazilyildiran@...il.com>, <kbuild-all@...ts.01.org>,
        <linux-kernel@...r.kernel.org>
Subject: RE: [char-misc:char-misc-testing 20/24] kismet: WARNING: unmet direct
 dependencies detected for GPIOLIB_IRQCHIP when selected by GP_PCI1XXXX

> -----Original Message-----
> From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Sent: Saturday, September 3, 2022 12:40 PM
> To: kernel test robot <lkp@...el.com>; Kumaravel Thiagarajan - I21417
> <Kumaravel.Thiagarajan@...rochip.com>; Paul Gazzillo <paul@...zz.com>;
> Necip Fazil Yildiran <fazilyildiran@...il.com>; kbuild-all@...ts.01.org; linux-
> kernel@...r.kernel.org
> Subject: Re: [char-misc:char-misc-testing 20/24] kismet: WARNING: unmet
> direct dependencies detected for GPIOLIB_IRQCHIP when selected by
> GP_PCI1XXXX
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> On Sat, Sep 03, 2022 at 02:12:13PM +0800, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-
> misc.git char-misc-testing
> > head:   4ec7ac90ff399b7d9af81cc8afd430a22786c61b
> > commit: 393fc2f5948fd340d016a9557eea6e1ac2f6c60c [20/24] misc:
> microchip: pci1xxxx: load auxiliary bus driver for the PIO function in the multi-
> function endpoint of pci1xxxx device.
> > config: x86_64-kismet-CONFIG_GPIOLIB_IRQCHIP-CONFIG_GP_PCI1XXXX-
> 0-0
> > (https://download.01.org/0day-
> ci/archive/20220903/202209031414.Y8YCEjm
> > I-lkp@...el.com/config)
> > reproduce:
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-
> misc.git/commit/?id=393fc2f5948fd340d016a9557eea6e1ac2f6c60c
> >         git remote add char-misc
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
> >         git fetch --no-tags char-misc char-misc-testing
> >         git checkout 393fc2f5948fd340d016a9557eea6e1ac2f6c60c
> >         # 1. reproduce by kismet
> >            # install kmax per
> https://github.com/paulgazz/kmax/blob/master/README.md
> >            kismet --linux-ksrc=linux --selectees CONFIG_GPIOLIB_IRQCHIP --
> selectors CONFIG_GP_PCI1XXXX -a=x86_64
> >         # 2. reproduce by make
> >            # save the config file to linux source tree
> >            cd linux
> >            make ARCH=x86_64 olddefconfig
> >
> > If you fix the issue, kindly add following tag where applicable
> > Reported-by: kernel test robot <lkp@...el.com>
> >
> > kismet warnings: (new ones prefixed by >>)
> > >> kismet: WARNING: unmet direct dependencies detected for
> > >> GPIOLIB_IRQCHIP when selected by GP_PCI1XXXX
> >
> >    WARNING: unmet direct dependencies detected for GPIOLIB_IRQCHIP
> >      Depends on [n]: GPIOLIB [=n]
> >      Selected by [y]:
> >      - GP_PCI1XXXX [=y] && PCI [=y]
> 
> Ick, I missed this before in review.  Kumaravel, any chance you can make this
> a "depends" issue instead of a select one?

Greg, can I select both GPIOLIB & GPIOLIB_IRQCHIP like below?

config GP_PCI1XXXX
       tristate "Microchip PCI1XXXX PCIe to GPIO Expander + OTP/EEPROM manager"
       depends on PCI	
       select GPIOLIB
       select GPIOLIB_IRQCHIP
       help
         PCI1XXXX is a PCIe GEN 3 switch with one of the endpoints having
         multiple functions and one of the functions is a GPIO controller
         which also has registers to interface with the OTP and EEPROM.
         Select yes, no or module here to include or exclude the driver
         for the GPIO function.

or replace "select GPIOLIB_IRQCHIP" with "depends on GPIOLIB_IRQCHIP" like you mentioned?

Please advise.

I am not able to experiment with these options as my Linux development machine is not accessible
due to some maintenance activities in office during the weekend.

Thank You.

Regards,
Kumaravel