linux-kernel - Re: [PATCH] PM: wakeup: Add extra debugging statement for multiple active IRQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jc_MNm6-s=p1Kaymk72h4QEH12J33dadyiKB76muqLtQ@mail.gmail.com>
Date:   Sat, 3 Sep 2022 20:05:43 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Mario Limonciello <mario.limonciello@....com>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PM: wakeup: Add extra debugging statement for multiple
 active IRQs

On Thu, Aug 25, 2022 at 3:36 AM Mario Limonciello
<mario.limonciello@....com> wrote:
>
> Since commit cb1f65c1e1424 ("PM: s2idle: ACPI: Fix wakeup interrupts
> handling") was introduced the kernel can now handle multiple
> simultaneous interrupts during wakeup.  Ths uncovered some existing
> subtle firmware bugs where multiple IRQs are unintentionally active.
>
> To help with fixing those bugs add an extra message when PM debugging
> is enabled that can show the individual IRQs triggered as if a variety
> are fired they'll potentially be lost as /sys/power/pm_wakeup_irq only
> contains the first one that triggered the wakeup after resume is
> complete but all may be needed to demonstrate the whole picture.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=215770
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> ---
>  drivers/base/power/wakeup.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c
> index e3befa2c1b661..dcd06eac30afd 100644
> --- a/drivers/base/power/wakeup.c
> +++ b/drivers/base/power/wakeup.c
> @@ -943,6 +943,7 @@ void pm_system_irq_wakeup(unsigned int irq_number)
>                 wakeup_irq[1] = irq_number;
>         else
>                 irq_number = 0;
> +       pm_pr_dbg("Triggering wakeup from IRQ %d\n", irq_number);
>
>         raw_spin_unlock_irqrestore(&wakeup_irq_lock, flags);
>
> --

Applied as 6.1 material, thanks!