[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <58d05274-b460-638e-d363-930de897283a@amazon.com>
Date: Sat, 3 Sep 2022 22:12:13 +0300
From: "Farber, Eliav" <farbere@...zon.com>
To: Rob Herring <robh@...nel.org>
CC: <jdelvare@...e.com>, <linux@...ck-us.net>,
<p.zabel@...gutronix.de>, <rtanwar@...linear.com>,
<linux-hwmon@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <talel@...zon.com>,
<hhhawa@...zon.com>, <jonnyc@...zon.com>, <hanochu@...zon.com>,
<ronenk@...zon.com>, <itamark@...zon.com>, <shellykz@...zon.com>,
<shorer@...zon.com>, <amitlavi@...zon.com>, <almogbs@...zon.com>,
<dkl@...zon.com>, <andriy.shevchenko@...el.com>,
"Farber, Eliav" <farbere@...zon.com>
Subject: Re: [PATCH v3 14/19] dt-bindings: hwmon: (mr75203) add "moortec,
ts-series" property
On 9/2/2022 10:59 PM, Rob Herring wrote:
> On Tue, Aug 30, 2022 at 07:22:07PM +0000, Eliav Farber wrote:
>> Add optional "moortec,ts-series" property to define the temperature
>> equation and coefficients that shall be used to convert the digital
>> output to value in milli-Celsius.
>> Supported series: 5 (default) and 6.
>>
>> Series 5:
>> T = G + H * (n / cal5 - 0.5) + J * F
>> Where: G = 60, H = 200, cal5 = 4094, J = -0.1, F = frequency clock in
>> MHz
>>
>> Series 6:
>> T = G + H * (n / cal5 - 0.5)
>> Where: G = 57.4, H = 249.4, cal5 = 4096
>>
>> Signed-off-by: Eliav Farber <farbere@...zon.com>
>> ---
>> V3 -> V2:
>> - New patch to introduce "moortec,ts-series" property.
>>
>> .../devicetree/bindings/hwmon/moortec,mr75203.yaml | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
>> b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
>> index 4c983d8f8fe7..ec2dbe7da9c2 100644
>> --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
>> +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
>> @@ -64,6 +64,16 @@ properties:
>> default: 1
>> $ref: /schemas/types.yaml#definitions/uint8-array
>>
>> + moortec,ts-series:
>> + description:
>> + moortec,ts-series defines the temperature equation and
>> coefficients that
>> + shall be used to convert the digital output to value in
>> milli-Celsius.
>> + Supported series are 5 and 6.
>
> No need to state constraints in free-form text descriptions.
Fixed in v4.
Powered by blists - more mailing lists