linux-kernel - Re: [PATCH v1] drivers/ata/libata-core: check return value of sata_scr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMEuxRppGCcmNjs7+TBG8Z82ShG2-Pj7dcLfVsb+tUK6GPeh6w@mail.gmail.com>
Date:   Sat, 3 Sep 2022 16:05:19 -0700
From:   Li Zhong <floridsleeves@...il.com>
To:     Damien Le Moal <Damien.LeMoal@....com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>,
        "damien.lemoal@...nsource.wdc.com" <damien.lemoal@...nsource.wdc.com>
Subject: Re: [PATCH v1] drivers/ata/libata-core: check return value of sata_scr_read()

On Mon, Aug 29, 2022 at 6:38 PM Damien Le Moal <Damien.LeMoal@....com> wrote:
>
> On 2022/08/29 5:45, Li Zhong wrote:
> > sata_scr_read() could return 0 on failure. Check the return value.
>
> Looks OK as a fix but the above sentence has a bug. 0 indicates success, not
> failure. So this should read:
>
> sata_scr_read() may fail with a negative error code. Check that function return
> value when reading the control register.
>
> Also, the patch title should be something like:
>
> ata: libata-core: Check errors in sata_print_link_status()
>

Thanks. Will fix it in the new version.

> >
> > Signed-off-by: Li Zhong <floridsleeves@...il.com>
> > ---
> >  drivers/ata/libata-core.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> > index 826d41f341e4..ae08c7d35cb0 100644
> > --- a/drivers/ata/libata-core.c
> > +++ b/drivers/ata/libata-core.c
> > @@ -3021,7 +3021,8 @@ static void sata_print_link_status(struct ata_link *link)
> >
> >       if (sata_scr_read(link, SCR_STATUS, &sstatus))
> >               return;
> > -     sata_scr_read(link, SCR_CONTROL, &scontrol);
> > +     if (sata_scr_read(link, SCR_CONTROL, &scontrol))
> > +             return;
> >
> >       if (ata_phys_link_online(link)) {
> >               tmp = (sstatus >> 4) & 0xf;
>
> --
> Damien Le Moal
> Western Digital Research
>