linux-kernel - Re: [PATCH 0/4] ARM: footbridge: cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wnajuzyj.wl-maz@kernel.org>
Date:   Sun, 04 Sep 2022 12:43:48 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Arnd Bergmann <arnd@...db.de>,
        Russell King <linux@...linux.org.uk>,
        Christoph Hellwig <hch@....de>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH 0/4] ARM: footbridge: cleanups

On Thu, 18 Aug 2022 22:15:46 +0100,
Arnd Bergmann <arnd@...nel.org> wrote:
> 
> From: Arnd Bergmann <arnd@...db.de>
> 
> I had an older patch to remove the addin mode for footbridge,
> which nobody is using any more, and I found a few other small
> cleanups that are worth doing here.
> 
> Footbridge is now the only platform with a custom __virt_to_bus()
> for ISA DMA, and a custom phys_to_dma() for PCI devices. Both
> just add a fixed offset, so there is probably a better way
> of doing the same without a custom helper function.
> 
>      Arnd
> 
> Arnd Bergmann (4):
>   ARM: footbridge: remove addin mode
>   ARM: footbridge: remove leftover from personal-server
>   ARM: footbridge: move isa-dma support into footbridge
>   ARM: footbridge: limit CONFIG_ISA to CATS
> 
>  arch/arm/Kconfig                              |  5 --
>  arch/arm/include/asm/hardware/dec21285.h      | 13 ----
>  arch/arm/kernel/Makefile                      |  1 -
>  arch/arm/mach-footbridge/Kconfig              | 30 +-------
>  arch/arm/mach-footbridge/Makefile             |  5 +-
>  arch/arm/mach-footbridge/common.c             | 73 ++-----------------
>  arch/arm/mach-footbridge/dc21285.c            | 61 +++++-----------
>  .../arm/{kernel => mach-footbridge}/dma-isa.c |  7 +-
>  arch/arm/mach-footbridge/dma.c                | 58 ---------------
>  .../mach-footbridge/include/mach/isa-dma.h    | 14 +---
>  .../arm/mach-footbridge/include/mach/memory.h | 22 ------
>  arch/arm/mach-footbridge/isa.c                | 14 ++--
>  drivers/tty/serial/21285.c                    |  3 -
>  13 files changed, 42 insertions(+), 264 deletions(-)
>  rename arch/arm/{kernel => mach-footbridge}/dma-isa.c (98%)
>  delete mode 100644 arch/arm/mach-footbridge/dma.c
> 
> -- 
> 2.29.2
> 
> Cc: Russell King <linux@...linux.org.uk>
> Cc: Christoph Hellwig <hch@....de>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Marc Zyngier <maz@...nel.org>

I finally managed to give this a go on my netwinder using v2 of patch
5/4 (!), and the box booted nicely.

Note that apart from the serial console, everything I'm using on this
box is PCI (I tried to enable sound and failed, probably because I
can't select CONFIG_ISA anymore on this machine).

Anyway, for the purpose of this series:

Tested-by: Marc Zyngier <maz@...nel.org>

	   M.

-- 
Without deviation from the norm, progress is not possible.