linux-kernel - Re: [PATCH v11 2/3] phy: qcom-snps: Add support for overriding phy tuning parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YxTBewhBecSgXvPq@matsya>
Date:   Sun, 4 Sep 2022 20:47:15 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Krishna Kurapati PSSNV <quic_kriskura@...cinc.com>
Cc:     Bjorn Andersson <andersson@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Doug Anderson <dianders@...omium.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        Wesley Cheng <quic_wcheng@...cinc.com>,
        devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-phy@...ts.infradead.org, quic_pkondeti@...cinc.com,
        quic_ppratap@...cinc.com, quic_vpulyala@...cinc.com
Subject: Re: [PATCH v11 2/3] phy: qcom-snps: Add support for overriding phy
 tuning parameters

On 31-08-22, 18:41, Krishna Kurapati PSSNV wrote:
 
> > The ordering of this list needs to match the order of
> > override_param_map[] and there's nothing indicating this in the code.
> > 
> > I was considering suggesting that you add a enum/define and do
> > 	[SQUELCH_DETECTOR_BP] = "qcom,squelch-detector-bp",
> > 	...
> > and then do the same in the override_param_map array.
> > >
> > But I think it will be cleaner if you add a const char const pointer to
> > override_param_map and just specify these strings in the
> > override_param_map array.
> > 
> > Each entry will grow by a pointer, but multiple copies of the same
> > strings (when added in the future) should be combined by the compiler.
> > 
> IIUC, you want me to remove this array of const char*'s and embed them in
> the override_param_map and iterate through it without using this const
> phy_seq_props as a reference.

I think that would make it simpler.. 

> > > +static const struct override_param_map sc7280[] = {
> > 
> > There's nothing ensuring that the loop below doesn't run off the end of
> > this array. So when the next platform is added, there's no way to
> > handle the fact that they might have a different set of properties.
> > 
> > If you add the property name to these elements, that will no longer be a
> > problem (and you can add a {} entry at the end of the list and check for
> > this when looping over the elements.

Would be great if this is addressed as well

-- 
~Vinod