linux-kernel - Re: [PATCH v2 3/3] iio: temperature: mlx90632 Change return value of sensor measurement channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220904154923.33b79d83@jic23-huawei>
Date:   Sun, 4 Sep 2022 15:49:23 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     cmo@...exis.com
Cc:     linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andy Shevchenko <andy.shevchenko@...il.com>
Subject: Re: [PATCH v2 3/3] iio: temperature: mlx90632 Change return value
 of sensor measurement channel

On Sun,  4 Sep 2022 00:24:22 +0200
cmo@...exis.com wrote:

> From: Crt Mori <cmo@...exis.com>
> 
> The current EINVAL value is more applicable to embedded library, where
> user can actually put the fixed value to the sensor. In case of the
> driver if the value of the channel is invalid it is better in inform
> userspace that Channel was out of range as that implies more to internal
> driver error than invalid input. It also makes for easier debugging of
> where the error comes from during the development.
> 
> Signed-off-by: Crt Mori <cmo@...exis.com>
Hmm. That's an obscure return value - I think it's mostly going to confuse
anyone who ever gets it.  So not sure this change is wise even though the
descriptive text for that one does seem very much suited to this usecase.

> ---
>  drivers/iio/temperature/mlx90632.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/temperature/mlx90632.c b/drivers/iio/temperature/mlx90632.c
> index 37edd324d6a1..d511d36942d3 100644
> --- a/drivers/iio/temperature/mlx90632.c
> +++ b/drivers/iio/temperature/mlx90632.c
> @@ -435,7 +435,7 @@ static int mlx90632_channel_new_select(int perform_ret, uint8_t *channel_new,
>  		*channel_old = 1;
>  		break;
>  	default:
> -		return -EINVAL;
> +		return -ECHRNG;
>  	}
>  
>  	return 0;