[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202209050636.fDwfcdrU-lkp@intel.com>
Date: Mon, 5 Sep 2022 07:08:32 +0800
From: kernel test robot <lkp@...el.com>
To: hezhongkun <hezhongkun.hzk@...edance.com>, hannes@...xchg.org,
mhocko@...nel.org, roman.gushchin@...ux.dev
Cc: kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
cgroups@...r.kernel.org, linux-mm@...ck.org,
lizefan.x@...edance.com, wuyun.abel@...edance.com,
Zhongkun He <hezhongkun.hzk@...edance.com>
Subject: Re: [PATCH] cgroup/cpuset: Add a new isolated mems.policy type.
Hi hezhongkun,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on c40e8341e3b3bb27e3a65b06b5b454626234c4f0]
url: https://github.com/intel-lab-lkp/linux/commits/hezhongkun/cgroup-cpuset-Add-a-new-isolated-mems-policy-type/20220904-120436
base: c40e8341e3b3bb27e3a65b06b5b454626234c4f0
config: ia64-randconfig-c44-20220904
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/aafa4e2c9e5c3cd4d02190ac2a7ed0654ed9cf47
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review hezhongkun/cgroup-cpuset-Add-a-new-isolated-mems-policy-type/20220904-120436
git checkout aafa4e2c9e5c3cd4d02190ac2a7ed0654ed9cf47
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
kernel/cgroup/cpuset.c: In function 'cpuset_mpol_write':
>> kernel/cgroup/cpuset.c:2526:15: error: implicit declaration of function 'mpol_parse_str'; did you mean 'mpol_to_str'? [-Werror=implicit-function-declaration]
2526 | err = mpol_parse_str(buf, &mpol);
| ^~~~~~~~~~~~~~
| mpol_to_str
kernel/cgroup/cpuset.c:2515:20: warning: unused variable 'cs_allowed' [-Wunused-variable]
2515 | nodemask_t cs_allowed;
| ^~~~~~~~~~
cc1: some warnings being treated as errors
vim +2526 kernel/cgroup/cpuset.c
2508
2509 /* change cpuset mempolicy */
2510 static ssize_t cpuset_mpol_write(struct kernfs_open_file *of,
2511 char *buf, size_t nbytes, loff_t off)
2512 {
2513 struct mempolicy *mpol, *old = NULL;
2514 struct cpuset *cs = css_cs(of_css(of));
2515 nodemask_t cs_allowed;
2516 int err = -ENODEV;
2517
2518 css_get(&cs->css);
2519 kernfs_break_active_protection(of->kn);
2520 percpu_down_write(&cpuset_rwsem);
2521
2522 if (!is_cpuset_online(cs))
2523 goto out_unlock;
2524
2525 buf = strstrip(buf);
> 2526 err = mpol_parse_str(buf, &mpol);
2527
2528 if (err) {
2529 err = -EINVAL;
2530 goto out_unlock;
2531 }
2532
2533 spin_lock_irq(&callback_lock);
2534 old = cs->mempolicy;
2535 update_cs_mpol_nodemask(cs, mpol);
2536 cs->mempolicy = mpol;
2537 spin_unlock_irq(&callback_lock);
2538
2539 update_tasks_cs_mpol(cs);
2540
2541 out_unlock:
2542 percpu_up_write(&cpuset_rwsem);
2543 kernfs_unbreak_active_protection(of->kn);
2544 css_put(&cs->css);
2545
2546 if (old) {
2547 /*Wait for outstanding programs to complete.*/
2548 synchronize_rcu();
2549 mpol_put(old);
2550 }
2551 return err ?: nbytes;
2552 }
2553
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (148936 bytes)
Powered by blists - more mailing lists