linux-kernel - RE: [PATCH v7 11/15] mei: gsc: setup gsc extended operational memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 4 Sep 2022 07:29:04 +0000
From:   "Usyskin, Alexander" <alexander.usyskin@...el.com>
To:     "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@...el.com>,
        "Winkler, Tomas" <tomas.winkler@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>
CC:     Jani Nikula <jani.nikula@...ux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@...el.com>,
        Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>,
        "intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Lubart, Vitaly" <vitaly.lubart@...el.com>
Subject: RE: [PATCH v7 11/15] mei: gsc: setup gsc extended operational memory

> > +static void pxp_is_ready(struct mei_cl_device *cldev)
> > +{
> > +	struct mei_device *bus = cldev->bus;
> > +
> > +	switch (bus->pxp_mode) {
> > +	case MEI_DEV_PXP_READY:
> > +	case MEI_DEV_PXP_DEFAULT:
> > +		cldev->do_match = 1;
> 
> Can you explain why you set do_match = 1 with MEI_DEV_PXP_DEFAULT ?
> AFAIU MEI_DEV_PXP_DEFAULT means that we haven't even started to
> initialize PXP, so it seems weird to match in that scenario.
> 
> Apart from this, the patch LGTM.
> 
> Daniele

MEI_DEV_PXP_DEFAULT is a state for the legacy PXP solution that uses the same firmware client
and have no need in special initialization.

-- 
Thanks,
Sasha