linux-kernel - Re: [PATCH v3] vfio/fsl-mc: Fix a typo in a message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <30b52449-7024-8911-6373-fb2167247880@oss.nxp.com>
Date:   Mon, 5 Sep 2022 19:01:12 +0300
From:   Diana Madalina Craciun <diana.craciun@....nxp.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Alex Williamson <alex.williamson@...hat.com>,
        Cornelia Huck <cohuck@...hat.com>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        kvm@...r.kernel.org
Subject: Re: [PATCH v3] vfio/fsl-mc: Fix a typo in a message

Reviewed-by: Diana Craciun <diana.craciun@....nxp.com>

On 9/2/2022 7:07 PM, Christophe JAILLET wrote:
> L and S are swapped in the message.
> s/VFIO_FLS_MC/VFIO_FSL_MC/
>
> Also use 'ret' instead of 'WARN_ON(ret)' to avoid a duplicated message.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> Changes in v3:
>    * Remove WARN_ON() and WARN() and only keep dev_warn()   [Diana Madalina Craciun <diana.craciun@....nxp.com>]
>
> Changes in v2:
>    * s/comment/message/ in the subject   [Cornelia Huck <cohuck@...hat.com>]
>    * use WARN instead of WARN_ON+dev_warn   [Jason Gunthorpe <jgg@...pe.ca>]
>    https://lore.kernel.org/all/3d2aa8434393ee8d2aa23a620e59ce1059c9d7ad.1660663440.git.christophe.jaillet@wanadoo.fr/
>
> v1:
>    https://lore.kernel.org/all/2b65bf8d2b4d940cafbafcede07c23c35f042f5a.1659815764.git.christophe.jaillet@wanadoo
> ---
>   drivers/vfio/fsl-mc/vfio_fsl_mc.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/vfio/fsl-mc/vfio_fsl_mc.c b/drivers/vfio/fsl-mc/vfio_fsl_mc.c
> index 3feff729f3ce..42b344bd7cd5 100644
> --- a/drivers/vfio/fsl-mc/vfio_fsl_mc.c
> +++ b/drivers/vfio/fsl-mc/vfio_fsl_mc.c
> @@ -108,9 +108,9 @@ static void vfio_fsl_mc_close_device(struct vfio_device *core_vdev)
>   	/* reset the device before cleaning up the interrupts */
>   	ret = vfio_fsl_mc_reset_device(vdev);
>   
> -	if (WARN_ON(ret))
> +	if (ret)
>   		dev_warn(&mc_cont->dev,
> -			 "VFIO_FLS_MC: reset device has failed (%d)\n", ret);
> +			 "VFIO_FSL_MC: reset device has failed (%d)\n", ret);
>   
>   	vfio_fsl_mc_irqs_cleanup(vdev);
>