linux-kernel - Re: [PATCH RESEND] sched/topology: Add __init for init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Sep 2022 13:34:55 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Bing Huang <huangbing775@....com>, rostedt@...dmis.org,
        dietmar.eggemann@....com
Cc:     brauner@...nel.org, bristot@...hat.com, bsegall@...gle.com,
        juri.lelli@...hat.com, linux-kernel@...r.kernel.org,
        mgorman@...e.de, mingo@...hat.com, peterz@...radead.org,
        vincent.guittot@...aro.org
Subject: Re: [PATCH RESEND] sched/topology: Add __init for init_defrootdomain



On 8/31/22 02:39, Bing Huang wrote:
> From: Bing Huang <huangbing@...inos.cn>
> 
> init_defrootdomain is only used in initialization
> 
> Signed-off-by: Bing Huang <huangbing@...inos.cn>


Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  kernel/sched/sched.h    | 2 +-
>  kernel/sched/topology.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index b0bf2287dd9d..cd761f1fc60c 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -883,7 +883,7 @@ struct root_domain {
>  	struct perf_domain __rcu *pd;
>  };
>  
> -extern void init_defrootdomain(void);
> +extern void __init init_defrootdomain(void);
>  extern int sched_init_domains(const struct cpumask *cpu_map);
>  extern void rq_attach_root(struct rq *rq, struct root_domain *rd);
>  extern void sched_get_rd(struct root_domain *rd);
> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
> index 8739c2a5a54e..dea9fa39e7c0 100644
> --- a/kernel/sched/topology.c
> +++ b/kernel/sched/topology.c
> @@ -578,7 +578,7 @@ static int init_rootdomain(struct root_domain *rd)
>   */
>  struct root_domain def_root_domain;
>  
> -void init_defrootdomain(void)
> +void __init init_defrootdomain(void)
>  {
>  	init_rootdomain(&def_root_domain);
>  

-- 
~Randy