linux-kernel - Re: [PATCH] arm64: dts: rockchip: Fix SD card controller probe on Pinephone Pro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00406e34-dee8-ba68-f2dd-c0c0634b42f6@tom-fitzhenry.me.uk>
Date:   Tue, 6 Sep 2022 06:52:53 +1000
From:   Tom Fitzhenry <tom@...-fitzhenry.me.uk>
To:     Ondrej Jirman <megi@....cz>, linux-rockchip@...ts.infradead.org
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Heiko Stuebner <heiko@...ech.de>,
        Martijn Braam <martijn@...xit.nl>,
        Caleb Connolly <kc@...tmarketos.org>,
        Arnaud Ferraris <arnaud.ferraris@...il.com>,
        Nícolas F. R. A. Prado <n@...aprado.net>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "moderated list:ARM/Rockchip SoC support" 
        <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: rockchip: Fix SD card controller probe on
 Pinephone Pro

On 5/9/22 09:36, Ondrej Jirman wrote:
> Voltage constraints on vccio_sd are invalid. They don't match the voltages
> that LDO9 can generate, and this causes rk808-regulator driver to fail
> to probe with -EINVAL when it tries to apply the constraints during boot.

On most boots, the SD card probe succeeds, and is able to be mounted.

On some boots, however, I observe this bug with error message:

vccio_sd: failed to apply 3150000-3150000uV constraint: -EINVAL

> 
> Fix the constraints to something that LDO9 can be actually configured for.
> 
> Fixes: 78a21c7d5952 ("arm64: dts: rockchip: Add initial support for Pine64 PinePhone Pro")
> Signed-off-by: Ondrej Jirman <megi@....cz>

Reviewed-by: Tom Fitzhenry <tom@...-fitzhenry.me.uk>
Tested-by: Tom Fitzhenry <tom@...-fitzhenry.me.uk>