[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <YxWYA0dTKXGKHwKF@matsya>
Date: Mon, 5 Sep 2022 12:02:35 +0530
From: Vinod Koul <vkoul@...nel.org>
To: Jean Delvare <jdelvare@...e.de>
Cc: LKML <linux-kernel@...r.kernel.org>, dmaengine@...r.kernel.org,
Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>
Subject: Re: [PATCH] dmaengine: dw-axi-dmac: Drop obsolete dependency on
COMPILE_TEST
On 03-08-22, 22:34, Jean Delvare wrote:
> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> is possible to test-build any driver which depends on OF on any
> architecture by explicitly selecting OF. Therefore depending on
> COMPILE_TEST as an alternative is no longer needed.
>
> It is actually better to always build such drivers with OF enabled,
> so that the test builds are closer to how each driver will actually be
> built on its intended target. Building them without OF may not test
> much as the compiler will optimize out potentially large parts of the
> code. In the worst case, this could even pop false positive warnings.
> Dropping COMPILE_TEST here improves the quality of our testing and
> avoids wasting time on non-existent issues.
Applied, thanks
--
~Vinod
Powered by blists - more mailing lists