Date:   Mon, 05 Sep 2022 09:29:44 +0200
From:   Michael Walle <michael@...le.cc>
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Xiaoliang Yang <xiaoliang.yang_1@....com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        UNGLinuxDriver@...rochip.com, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vinicius Costa Gomes <vinicius.gomes@...el.com>,
        Maxim Kochetkov <fido_max@...ox.ru>,
        Colin Foster <colin.foster@...advantage.com>,
        Richie Pearn <richard.pearn@....com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 1/3] net: dsa: felix: allow small tc-taprio windows to
 send at least some packets

Hi,

Am 2022-09-02 23:57, schrieb Vladimir Oltean:
> The blamed commit broke tc-taprio schedules such as this one:
> 
> tc qdisc replace dev $swp1 root taprio \
> 	num_tc 8 \
> 	map 0 1 2 3 4 5 6 7 \
> 	queues 1@0 1@1 1@2 1@3 1@4 1@5 1@6 1@7 \
> 	base-time 0 \
> 	sched-entry S 0x7f 990000 \
> 	sched-entry S 0x80  10000 \
> 	flags 0x2
> 
> because the gate entry for TC 7 (S 0x80 10000 ns) now has a static 
> guard
> band added earlier than its 'gate close' event, such that packet
> overruns won't occur in the worst case of the largest packet possible.
> 
> Since guard bands are statically determined based on the per-tc
> QSYS_QMAXSDU_CFG_* with a fallback on the port-based QSYS_PORT_MAX_SDU,
> we need to discuss depending on kernel version, since the driver, prior
> to commit 55a515b1f5a9 ("net: dsa: felix: drop oversized frames with
> tc-taprio instead of hanging the port"), did not touch
> QSYS_QMAXSDU_CFG_*, and therefore relied on QSYS_PORT_MAX_SDU.
> 
> 1 (before vsc9959_tas_guard_bands_update): QSYS_PORT_MAX_SDU defaults 
> to
>   1518, and at gigabit this introduces a static guard band (independent
>   of packet sizes) of 12144 ns. But this is larger than the time window
>   itself, of 10000 ns. So, the queue system never considers a frame 
> with
>   TC 7 as eligible for transmission, since the gate practically never
>   opens, and these frames are forever stuck in the TX queues and hang
>   the port.

IIRC we deliberately ignored that problem back then, because we couldn't
set the maxsdu.

> 2 (after vsc9959_tas_guard_bands_update): We make an effort to set
>   QSYS_QMAXSDU_CFG_7 to 1230 bytes, and this enables oversized frame
>   dropping for everything larger than that. But QSYS_QMAXSDU_CFG_7 
> plays
>   2 roles. One is oversized frame dropping, the other is the per-tc
>   static guard band. When we calculated QSYS_QMAXSDU_CFG_7 to be 1230,
>   we considered no guard band at all, and the entire time window
>   available for transmission, which is not the case. The larger
>   QSYS_QMAXSDU_CFG_7 is, the larger the static guard band for the tc 
> is,
>   too.
> 
> In both cases, frames with any size (even 60 bytes sans FCS) are stuck
> on egress rather than being considered for scheduling on TC 7, even if
> they fit. This is because the static guard band is way too large.
> Considering the current situation, with 
> vsc9959_tas_guard_bands_update(),
> frames between 60 octets and 1230 octets in size are not eligible for
> oversized dropping (because they are smaller than QSYS_QMAXSDU_CFG_7),
> but won't be considered as eligible for scheduling either, because the
> min_gate_len[7] (10000 ns) - the guard band determined by
> QSYS_QMAXSDU_CFG_7 (1230 octets * 8 ns per octet == 9840 ns) is smaller
> than their transmit time.
> 
> A solution that is quite outrageous is to limit the minimum valid gate
> interval acceptable through tc-taprio, such that intervals, when
> transformed into L1 frame bit times, are never smaller than twice the
> MTU of the interface. However, the tc-taprio UAPI operates in ns, and
> the link speed can change at runtime (to 10 Mbps, where the 
> transmission
> time of 1 octet is 800 ns). And since the max MTU is around 9000, we'd
> have to limit the tc-taprio intervals to be no smaller than 14.4 ms on
> the premise that it is possible for the link to renegotiate to 10 Mbps,
> which is astonishingly limiting for real use cases, where the entire
> *cycle* (here we're talking about a single interval) must be 100 us or
> lower.
> 
> The solution is to modify vsc9959_tas_guard_bands_update() to take into
> account that the static per-tc guard bands consume time out of our time
> window too, not just packet transmission. The unknown which needs to be
> determined is the max admissible frame size. Both the useful bit time
> and the guard band size will depend on this unknown variable, so
> dividing the available 10000 ns into 2 halves sounds like the ideal
> strategy. In this case, we will program QSYS_QMAXSDU_CFG_7 with a
> maximum frame length (and guard band size) of 605 octets (this includes
> FCS but not IPG and preamble/SFD). With this value, everything of L2
> size 601 (sans FCS) and higher is considered as oversized, and the 
> guard
> band is low enough (605 + HSCH_MISC.FRM_ADJ, at 1Gbps => 5000 ns) in
> order to not disturb the scheduling of any frame smaller than L2 size 
> 601.

So one drawback with this is that you limit the maxsdu to match a
frame half of the gate open time, right?

The switch just schedule the *start* event of the frame. So even if
the guard band takes 99% of the gate open time, it should be able
to send a frame regardless of it's length during the first 1% of
the period (and it doesn't limit the maxsdu by half). IIRC the guard
band is exactly for that, that is that you don't know the frame
length and you can still schedule the frame. I know of switches
which don't use a guard band but know the exact length and the
closing time of the queue and deduce by that if the frame can
still be queued.

Actually, I'd expect it to work after your 
vsc9959_tas_guard_bands_update.
Hmm.

To quote from you above:
> min_gate_len[7] (10000 ns) - the guard band determined by
> QSYS_QMAXSDU_CFG_7 (1230 octets * 8 ns per octet == 9840 ns) is smaller
> than their transmit time.

Are you sure this is the case? There should be 160ns time to
schedule the start of the frame. Maybe the 160ns is just too
small.

-michael

Powered by blists - more mailing lists