linux-kernel - Re: [PATCH v3 01/22] KVM: x86: Drop kvm_user_return_msr_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YxVYEhsI9CGKtJZb@gao-cwp>
Date:   Mon, 5 Sep 2022 09:59:46 +0800
From:   Chao Gao <chao.gao@...el.com>
To:     <isaku.yamahata@...el.com>
CC:     <linux-kernel@...r.kernel.org>, <kvm@...r.kernel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Sean Christopherson <seanjc@...gle.com>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        Marc Zyngier <maz@...nel.org>, Will Deacon <will@...nel.org>,
        <isaku.yamahata@...il.com>, Kai Huang <kai.huang@...el.com>,
        Atish Patra <atishp@...shpatra.org>,
        Shaokun Zhang <zhangshaokun@...ilicon.com>,
        Qi Liu <liuqi115@...wei.com>,
        John Garry <john.garry@...wei.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        "Huang Ying" <ying.huang@...el.com>,
        Huacai Chen <chenhuacai@...nel.org>,
        "Dave Hansen" <dave.hansen@...ux.intel.com>,
        Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH v3 01/22] KVM: x86: Drop kvm_user_return_msr_cpu_online()

On Thu, Sep 01, 2022 at 07:17:36PM -0700, isaku.yamahata@...el.com wrote:
>-	user_return_msrs = alloc_percpu(struct kvm_user_return_msrs);
>+	/*
>+	 * __GFP_ZERO to ensure user_return_msrs.values[].initialized = false.
					^ should be user_return_msrs.initialized

With this fixed,

	Reviewed-by: Chao Gao <chao.gao@...el.com>