linux-kernel - Re: [PATCH 12/12] drm/udl: Sync pending URBs at the end of suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d3a0faf3-14ae-04a7-affe-4cd64570855f@suse.de>
Date:   Mon, 5 Sep 2022 10:44:25 +0200
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 12/12] drm/udl: Sync pending URBs at the end of suspend

Hi

Am 16.08.22 um 17:36 schrieb Takashi Iwai:
> It's better to perform the sync at the very last of the suspend
> instead of the pipe-disable function, so that we can catch all pending
> URBs (if any).
> 
> While we're at it, drop the error code from udl_sync_pending_urb()
> since we basically ignore it; instead, give a clear error message
> indicating a problem.

But if we fail, shouldn't we report that error to the caller of the 
suspend function?

Best regards
Thomas

> 
> Signed-off-by: Takashi Iwai <tiwai@...e.de>
> ---
>   drivers/gpu/drm/udl/udl_drv.c     | 8 +++++++-
>   drivers/gpu/drm/udl/udl_drv.h     | 2 +-
>   drivers/gpu/drm/udl/udl_main.c    | 6 ++----
>   drivers/gpu/drm/udl/udl_modeset.c | 2 --
>   4 files changed, 10 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/udl/udl_drv.c b/drivers/gpu/drm/udl/udl_drv.c
> index 0ba88e5472a9..91effdcefb6d 100644
> --- a/drivers/gpu/drm/udl/udl_drv.c
> +++ b/drivers/gpu/drm/udl/udl_drv.c
> @@ -21,8 +21,14 @@ static int udl_usb_suspend(struct usb_interface *interface,
>   			   pm_message_t message)
>   {
>   	struct drm_device *dev = usb_get_intfdata(interface);
> +	int ret;
>   
> -	return drm_mode_config_helper_suspend(dev);
> +	ret = drm_mode_config_helper_suspend(dev);
> +	if (ret)
> +		return ret;
> +
> +	udl_sync_pending_urbs(dev);
> +	return 0;
>   }
>   
>   static int udl_usb_resume(struct usb_interface *interface)
> diff --git a/drivers/gpu/drm/udl/udl_drv.h b/drivers/gpu/drm/udl/udl_drv.h
> index d943684b5bbb..b4cc7cc568c7 100644
> --- a/drivers/gpu/drm/udl/udl_drv.h
> +++ b/drivers/gpu/drm/udl/udl_drv.h
> @@ -77,7 +77,7 @@ struct drm_connector *udl_connector_init(struct drm_device *dev);
>   struct urb *udl_get_urb(struct drm_device *dev);
>   
>   int udl_submit_urb(struct drm_device *dev, struct urb *urb, size_t len);
> -int udl_sync_pending_urbs(struct drm_device *dev);
> +void udl_sync_pending_urbs(struct drm_device *dev);
>   void udl_urb_completion(struct urb *urb);
>   
>   int udl_init(struct udl_device *udl);
> diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/udl_main.c
> index c1f4b6199949..df92f6518e1c 100644
> --- a/drivers/gpu/drm/udl/udl_main.c
> +++ b/drivers/gpu/drm/udl/udl_main.c
> @@ -294,10 +294,9 @@ int udl_submit_urb(struct drm_device *dev, struct urb *urb, size_t len)
>   }
>   
>   /* wait until all pending URBs have been processed */
> -int udl_sync_pending_urbs(struct drm_device *dev)
> +void udl_sync_pending_urbs(struct drm_device *dev)
>   {
>   	struct udl_device *udl = to_udl(dev);
> -	int ret = 0;
>   
>   	spin_lock_irq(&udl->urbs.lock);
>   	/* 2 seconds as a sane timeout */
> @@ -305,9 +304,8 @@ int udl_sync_pending_urbs(struct drm_device *dev)
>   					 udl->urbs.available == udl->urbs.count,
>   					 udl->urbs.lock,
>   					 msecs_to_jiffies(2000)))
> -		ret = -ETIMEDOUT;
> +		drm_err(dev, "Timeout for syncing pending URBs\n");
>   	spin_unlock_irq(&udl->urbs.lock);
> -	return ret;
>   }
>   
>   int udl_init(struct udl_device *udl)
> diff --git a/drivers/gpu/drm/udl/udl_modeset.c b/drivers/gpu/drm/udl/udl_modeset.c
> index bca31c890108..9d72288d9967 100644
> --- a/drivers/gpu/drm/udl/udl_modeset.c
> +++ b/drivers/gpu/drm/udl/udl_modeset.c
> @@ -391,8 +391,6 @@ udl_simple_display_pipe_disable(struct drm_simple_display_pipe *pipe)
>   	buf = udl_dummy_render(buf);
>   
>   	udl_submit_urb(dev, urb, buf - (char *)urb->transfer_buffer);
> -
> -	udl_sync_pending_urbs(dev);
>   }
>   
>   static void

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)