linux-kernel - Re: [PATCH] drm/print: cleanup coding style in drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sfl6b3zb.fsf@intel.com>
Date:   Mon, 05 Sep 2022 11:49:28 +0300
From:   Jani Nikula <jani.nikula@...ux.intel.com>
To:     Jingyu Wang <jingyuwang_vip@....com>,
        maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
        tzimmermann@...e.de, airlied@...ux.ie, daniel@...ll.ch,
        Joe Perches <joe@...ches.com>
Cc:     Jingyu Wang <jingyuwang_vip@....com>, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/print: cleanup coding style in drm_print.h

On Mon, 05 Sep 2022, Jani Nikula <jani.nikula@...ux.intel.com> wrote:
> On Mon, 05 Sep 2022, Jingyu Wang <jingyuwang_vip@....com> wrote:
>> Fix everything checkpatch.pl complained about in drm_print.h

[...]

>>  static inline void
>> -drm_vprintf(struct drm_printer *p, const char *fmt, va_list *va)
>> +drm_vprintf(struct drm_printer *p, const char *fmt, va_list * va)
>
> Checkpatch is just confused here. Look at all the other params, why
> would you add an extra space here?

Joe, can you help me out here please, I can't figure out why checkpatch
is complaining here:

include/drm/drm_print.h:106: CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#106: FILE: include/drm/drm_print.h:106:
+drm_vprintf(struct drm_printer *p, const char *fmt, va_list *va)


BR,
Jani.

-- 
Jani Nikula, Intel Open Source Graphics Center