linux-kernel - Re: [PATCH v3 2/2] ARM: dts: aspeed: Add device tree for Ampere's Mt. Mitchell BMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <396a3c24-2a86-0d1c-07f9-386a0de1d473@os.amperecomputing.com>
Date:   Mon, 5 Sep 2022 16:45:45 +0700
From:   Quan Nguyen <quan@...amperecomputing.com>
To:     Arnd Bergmann <arnd@...db.de>, Joel Stanley <joel@....id.au>
Cc:     openbmc@...ts.ozlabs.org, Olof Johansson <olof@...om.net>,
        soc@...nel.org, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Andrew Jeffery <andrew@...id.au>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-aspeed@...ts.ozlabs.org,
        Open Source Submission <patches@...erecomputing.com>,
        Phong Vo <phong@...amperecomputing.com>,
        thang@...amperecomputing.com
Subject: Re: [PATCH v3 2/2] ARM: dts: aspeed: Add device tree for Ampere's Mt.
 Mitchell BMC



On 25/08/2022 19:35, Arnd Bergmann wrote:
> On Tue, Aug 23, 2022 at 10:27 AM Quan Nguyen
> <quan@...amperecomputing.com> wrote:
>> On 18/08/2022 19:06, Arnd Bergmann wrote:
>>
>> Thanks Arnd for the comment.
>>
>> I think adding -append could solve the issue.
>>
>> But as the bootargs still exist in all other
>> arch/arm/boot/dts/aspeed-bmc-*.dts should we still keep bootargs for
>> this dts?
> 
> I think it should still be removed. Only 238 of 2547 set the console using
> bootargs, so that would make it more consistent with the other files.
> 
> Changing the files that have the same issue is a separate matter.
> 

Hi Joel,

In the meantime, I'm just wonder if you could help to test the patch 
with -append and get it merged.

Thank you and best regards,
- Quan