linux-kernel - Re: [PATCH] checkpatch: warn for non-standard fixes tag style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YxXUHPWtyrt6kNI1@sleipner.dyn.berto.se>
Date:   Mon, 5 Sep 2022 12:49:00 +0200
From:   Niklas Söderlund 
        <niklas.soderlund@...igine.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Dwaipayan Ray <dwaipayanray1@...il.com>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Jonathan Corbet <corbet@....net>,
        Andy Whitcroft <apw@...onical.com>, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, oss-drivers@...igine.com,
        Simon Horman <simon.horman@...igine.com>,
        Louis Peens <louis.peens@...igine.com>
Subject: Re: [PATCH] checkpatch: warn for non-standard fixes tag style

Hi Joe,

Thanks for your feedback.

On 2022-08-29 23:06:43 -0400, Joe Perches wrote:
> > +			if ($line =~ 
> > /(fixes:)\s+([0-9a-f]{5,})\s+($balanced_parens)/i) {
> 
> Maybe use fixes:? so the colon is not required in poorly formed uses

I tried that but I think it brings more problems then it is worth. With 
that change the check would run for each line of the commit message that 
begins with the string 'fixes', not just in the tags section of the 
message. So it would warn for the commit message,

    The work on foo and bar introduced a bug that can be
    fixed by doing baz.

I think it's for this reason other checks for tags include the ':'.

> 
> > +				my $tag = $1;
> > +				$orig_commit = $2;
> > +				$title = $3;
> > +
> > +				$tag_case = 0 if $tag eq "Fixes:";
> > +				$tag_space = 0 if ($line =~ /^fixes: [0-9a-f]{5,} ($balanced_parens)/i);
> 
> fixes:? here too
> 
> Pity there's no simple way to consolidate this git commit test block
> with the existing git id commit block.

I agree.

-- 
Kind Regards,
Niklas Söderlund