linux-kernel - Re: [PATCH] io_uring/notif: Remove the unused function io_notif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e55fa28e-6f9c-dcb4-3406-95dfbea8387a@gmail.com>
Date:   Mon, 5 Sep 2022 12:41:18 +0100
From:   Pavel Begunkov <asml.silence@...il.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>, axboe@...nel.dk
Cc:     io-uring@...r.kernel.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] io_uring/notif: Remove the unused function
 io_notif_complete()

On 9/5/22 03:04, Jiapeng Chong wrote:
> The function io_notif_complete() is defined in the notif.c file, but not
> called elsewhere, so delete this unused function.

Yep, forgot to kill it, LGTM

Reviewed-by: Pavel Begunkov <asml.silence@...il.com>


> io_uring/notif.c:24:20: warning: unused function 'io_notif_complete' [-Wunused-function].
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2047
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>   io_uring/notif.c | 8 --------
>   1 file changed, 8 deletions(-)
> 
> diff --git a/io_uring/notif.c b/io_uring/notif.c
> index 96f076b175e0..1a7abd7e5ca5 100644
> --- a/io_uring/notif.c
> +++ b/io_uring/notif.c
> @@ -21,14 +21,6 @@ static void __io_notif_complete_tw(struct io_kiocb *notif, bool *locked)
>   	io_req_task_complete(notif, locked);
>   }
>   
> -static inline void io_notif_complete(struct io_kiocb *notif)
> -	__must_hold(&notif->ctx->uring_lock)
> -{
> -	bool locked = true;
> -
> -	__io_notif_complete_tw(notif, &locked);
> -}
> -
>   static void io_uring_tx_zerocopy_callback(struct sk_buff *skb,
>   					  struct ubuf_info *uarg,
>   					  bool success)

-- 
Pavel Begunkov