linux-kernel - Re: [PATCH] checkpatch: move duplicate sign off to separate warning type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d5ab81794ef1c666e947ed1f23570c175bf7d9d4.camel@perches.com>
Date:   Mon, 05 Sep 2022 06:59:49 -0700
From:   Joe Perches <joe@...ches.com>
To:     Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Andy Whitcroft <apw@...onical.com>,
        Dwaipayan Ray <dwaipayanray1@...il.com>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     linux-kernel@...r.kernel.org, Rob Clark <robdclark@...il.com>
Subject: Re: [PATCH] checkpatch: move duplicate sign off to separate warning
 type

On Mon, 2022-09-05 at 13:45 +0300, Dmitry Baryshkov wrote:
> Some maintainers prefer to allow duplicate signatures if that provides
> additional details about the patch flow. E.g. if the original patch
> author pulls the patch from the patchwork into the kernel branch, this
> can result in duplicate SOB tags from him, however this reflects the
> patch flow (one SOB for being the author, one SOB for pulling the patch,
> adding (and maybe fixing) tags and pushing the patch further.

I think that's poor process, but whatever...

> 
> To facilitate easily handling this kind of warnings, separate duplicate
> SOBs into the separate warning class ('DUPLICATE_SIGN_OFF').
> 
> Cc: Rob Clark <robdclark@...il.com>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 79e759aac543..f95d4ac19901 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3115,7 +3115,7 @@ sub process {
>  			$sig_nospace =~ s/\s//g;
>  			$sig_nospace = lc($sig_nospace);
>  			if (defined $signatures{$sig_nospace}) {
> -				WARN("BAD_SIGN_OFF",
> +				WARN("DUPLICATE_SIGN_OFF",
>  				     "Duplicate signature\n" . $herecurr);
>  			} else {
>  				$signatures{$sig_nospace} = 1;