linux-kernel - Re: [PATCH -next] rv/reactor: add __init/__exit annotations to module init/exit funcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 6 Sep 2022 22:21:24 +0800
From:   xiujianfeng <xiujianfeng@...wei.com>
To:     Daniel Bristot de Oliveira <bristot@...nel.org>
CC:     <linux-kernel@...r.kernel.org>, <rostedt@...dmis.org>,
        <mingo@...hat.com>
Subject: Re: [PATCH -next] rv/reactor: add __init/__exit annotations to module
 init/exit funcs

Hi,

在 2022/9/6 21:43, Daniel Bristot de Oliveira 写道:
> 
> Hi Xiu
> On 9/6/22 13:18, Xiu Jianfeng wrote:
>> Add missing __init/__exit annotations to module init/exit funcs.
> 
> Regarding the Subject, this patch is not -next. I would suggest only using -next
> when you are fixing something in the linux-next (which is not the case here).
> 
> You can also fix this for the printk reactor. Do you mind re-sending this patch
> with including the printk reactor?

No problem, V2 already sent.

> 
> If you found it using an automatic tool, please add information to the patch.
> Also, try to figure out why it pointed to the panic reactor but did not point to
> printk.

Thanks, I found it by review not tools.

> 
> Add to v2:
> 
> Fixes: 135b881ea885 ("rv/reactor: Add the printk reactor")
> Fixes: e88043c0ac16 ("rv/reactor: Add the panic reactor")
> 
>> Signed-off-by: Xiu Jianfeng <xiujianfeng@...wei.com>
> 
> Thanks
> -- Daniel
> .
>