linux-kernel - Re: [PATCH] drm/amd/display: fix memory leak when using debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YxdiBRCmhlrRxAz5@kroah.com>
Date:   Tue, 6 Sep 2022 17:06:45 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Rodrigo Siqueira Jordao <Rodrigo.Siqueira@....com>
Cc:     Harry Wentland <harry.wentland@....com>,
        Leo Li <sunpeng.li@....com>,
        Alex Deuc her <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        Xinhui.Pan@....com, linux-kernel@...r.kernel.org,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, Wayne Lin <Wayne.Lin@....com>,
        hersen wu <hersenxs.wu@....com>,
        Wenjing Liu <wenjing.liu@....com>,
        Patrik Jakobsson <patrik.r.jakobsson@...il.com>,
        Thelford Williams <tdwilliamsiv@...il.com>,
        Fangzhi Zuo <Jerry.Zuo@....com>,
        Yongzhi Liu <lyz_cs@....edu.cn>,
        Mikita Lipski <mikita.lipski@....com>,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        Bhanuprakash Modem <bhanuprakash.modem@...el.com>,
        Sean Paul <seanpaul@...omium.org>,
        amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/amd/display: fix memory leak when using
 debugfs_lookup()

On Tue, Sep 06, 2022 at 10:52:28AM -0400, Rodrigo Siqueira Jordao wrote:
> 
> 
> On 2022-09-02 09:10, Greg Kroah-Hartman wrote:
> > On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote:
> > > When calling debugfs_lookup() the result must have dput() called on it,
> > > otherwise the memory will leak over time.  Fix this up by properly
> > > calling dput().
> > > 
> > > Cc: Harry Wentland <harry.wentland@....com>
> > > Cc: Leo Li <sunpeng.li@....com>
> > > Cc: Rodrigo Siqueira <Rodrigo.Siqueira@....com>
> > > Cc: Alex Deucher <alexander.deucher@....com>
> > > Cc: "Christian König" <christian.koenig@....com>
> > > Cc: "Pan, Xinhui" <Xinhui.Pan@....com>
> > > Cc: David Airlie <airlied@...ux.ie>
> > > Cc: Daniel Vetter <daniel@...ll.ch>
> > > Cc: Wayne Lin <Wayne.Lin@....com>
> > > Cc: hersen wu <hersenxs.wu@....com>
> > > Cc: Wenjing Liu <wenjing.liu@....com>
> > > Cc: Patrik Jakobsson <patrik.r.jakobsson@...il.com>
> > > Cc: Thelford Williams <tdwilliamsiv@...il.com>
> > > Cc: Fangzhi Zuo <Jerry.Zuo@....com>
> > > Cc: Yongzhi Liu <lyz_cs@....edu.cn>
> > > Cc: Mikita Lipski <mikita.lipski@....com>
> > > Cc: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> > > Cc: Bhanuprakash Modem <bhanuprakash.modem@...el.com>
> > > Cc: Sean Paul <seanpaul@...omium.org>
> > > Cc: amd-gfx@...ts.freedesktop.org
> > > Cc: dri-devel@...ts.freedesktop.org
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > > ---
> > 
> > Despite a zillion cc: items, I forgot to cc: stable on this.  Can the
> > maintainer add that here, or do you all want me to resend it with that
> > item added?
> > 
> > thanks,
> > 
> > greg k-h
> 
> Hi Greg,
> 
> Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@....com>
> 
> Is 'Cc: stable@...r.kernel.org' enough here? I can make this change before I
> merge it into amd-staging-drm-next.

Yes, please add the cc: stable@ line to the body of the patch, sorry I
forgot that.

thanks,

greg k-h