linux-kernel - Re: [PATCH 1/8] memory: tegra: Add API for retrieving carveout bounds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Sep 2022 23:25:29 +0800
From:   kernel test robot <lkp@...el.com>
To:     Mikko Perttunen <cyndis@...si.fi>,
        Thierry Reding <thierry.reding@...il.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Jonathan Hunter <jonathanh@...dia.com>
Cc:     kbuild-all@...ts.01.org, devicetree@...r.kernel.org,
        Sameer Pujar <spujar@...dia.com>, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org,
        Mikko Perttunen <mperttunen@...dia.com>,
        linux-tegra@...r.kernel.org, Ashish Mhetre <amhetre@...dia.com>
Subject: Re: [PATCH 1/8] memory: tegra: Add API for retrieving carveout bounds

Hi Mikko,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on clk/clk-next krzk-mem-ctrl/for-next pza/reset/next linus/master v6.0-rc4 next-20220906]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mikko-Perttunen/Support-for-NVDEC-on-Tegra234/20220906-215151
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: powerpc-allyesconfig (https://download.01.org/0day-ci/archive/20220906/202209062313.buowJWo0-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/7e2bd1173420c8e09ec90e3322e059a7350482e3
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Mikko-Perttunen/Support-for-NVDEC-on-Tegra234/20220906-215151
        git checkout 7e2bd1173420c8e09ec90e3322e059a7350482e3
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/memory/tegra/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/memory/tegra/mc.c: In function 'tegra_mc_get_carveout_info':
>> drivers/memory/tegra/mc.c:124:83: warning: left shift count >= width of type [-Wshift-count-overflow]
     124 |         *base |= (phys_addr_t)mc_ch_readl(mc, MC_BROADCAST_CHANNEL, offset + 0x4) << 32;
         |                                                                                   ^~


vim +124 drivers/memory/tegra/mc.c

   109	
   110	int tegra_mc_get_carveout_info(struct tegra_mc *mc, unsigned int id,
   111	                               phys_addr_t *base, u64 *size)
   112	{
   113		u32 offset;
   114	
   115		if (id < 1 || id >= mc->soc->num_carveouts)
   116			return -EINVAL;
   117	
   118		if (id < 6)
   119			offset = 0xc0c + 0x50 * (id - 1);
   120		else
   121			offset = 0x2004 + 0x50 * (id - 6);
   122	
   123		*base = mc_ch_readl(mc, MC_BROADCAST_CHANNEL, offset + 0x0);
 > 124		*base |= (phys_addr_t)mc_ch_readl(mc, MC_BROADCAST_CHANNEL, offset + 0x4) << 32;
   125	
   126		if (size)
   127			*size = mc_ch_readl(mc, MC_BROADCAST_CHANNEL, offset + 0x8) << 17;
   128	
   129		return 0;
   130	}
   131	EXPORT_SYMBOL_GPL(tegra_mc_get_carveout_info);
   132	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp