linux-kernel - Re: [PATCH linux-next] drm/amd/display: Remove the unneeded result variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <df28cb7b-f19d-fd8e-d1b7-dd893e3d2c77@amd.com>
Date:   Tue, 6 Sep 2022 11:44:53 -0400
From:   Rodrigo Siqueira Jordao <Rodrigo.Siqueira@....com>
To:     cgel.zte@...il.com, harry.wentland@....com
Cc:     sunpeng.li@....com, alexander.deucher@....com,
        christian.koenig@....com, Xinhui.Pan@....com, airlied@...ux.ie,
        daniel@...ll.ch, wenjing.liu@....com, Jun.Lei@....com,
        Jimmy.Kizito@....com, Jerry.Zuo@....com,
        meenakshikumar.somasundaram@....com, hanghong.ma@....com,
        amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org,
        zhang songyi <zhang.songyi@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] drm/amd/display: Remove the unneeded result
 variable



On 2022-09-02 03:54, cgel.zte@...il.com wrote:
> From: zhang songyi <zhang.songyi@....com.cn>
> 
> Return the enable_link_dp() directly instead of storing it in another
> redundant variable.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: zhang songyi <zhang.songyi@....com.cn>
> ---
>   drivers/gpu/drm/amd/display/dc/core/dc_link.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index f9b798b7933c..4ab27e231337 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -2077,11 +2077,7 @@ static enum dc_status enable_link_edp(
>   		struct dc_state *state,
>   		struct pipe_ctx *pipe_ctx)
>   {
> -	enum dc_status status;
> -
> -	status = enable_link_dp(state, pipe_ctx);
> -
> -	return status;
> +	return enable_link_dp(state, pipe_ctx);
>   }
>   
>   static enum dc_status enable_link_dp_mst(

LGTM,

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@....com>

and applied to amd-staging-drm-next.

Thanks
Siqueira