linux-kernel - Re: [PATCH v5] vfs, security: Fix automount superblock LSM init problem, preventing NFS sb sharing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <93ff2f6d8c49091c0aa8a008695da5150c096be3.camel@kernel.org>
Date:   Tue, 06 Sep 2022 12:02:55 -0400
From:   Jeff Layton <jlayton@...nel.org>
To:     David Howells <dhowells@...hat.com>
Cc:     viro@...iv.linux.org.uk,
        Trond Myklebust <trond.myklebust@...merspace.com>,
        Anna Schumaker <anna@...nel.org>,
        Scott Mayhew <smayhew@...hat.com>,
        Paul Moore <paul@...l-moore.com>,
        Casey Schaufler <casey@...aufler-ca.com>,
        linux-nfs@...r.kernel.org, selinux@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, dwysocha@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] vfs, security: Fix automount superblock LSM init
 problem, preventing NFS sb sharing

On Tue, 2022-09-06 at 17:01 +0100, David Howells wrote:
> Jeff Layton <jlayton@...nel.org> wrote:
> 
> > If this or the other allocations below fail, do you need to free the
> > prior ones here? Or do they automagically get cleaned up somehow?
> 
> Once the fs_context is allocated, it will always get cleaned up with
> put_fs_context(), which will dispose of the partially constructed
> smack_mnt_opts struct.
> 


Ok! In that case, you can add:

Reviewed-by: Jeff Layton <jlayton@...nel.org>